Add expiration seconds to binding params #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KsaweryZietara
added
the
kind/enhancement
kyma-bot
added
cla: yes
|
Add one of following labels |
KsaweryZietara
added
the
do-not-merge/hold
jaroslaw-pieszka
previously approved these changes
Sep 25, 2024
ralikio
reviewed
Sep 25, 2024
ralikio
reviewed
Sep 25, 2024
ralikio
reviewed
Sep 25, 2024
internal/broker/bind_create_test.go
Outdated
| require.NoError(t, err) | ||
| t.Logf("binding: %v", binding.Credentials) | ||
| assert.Equal(t, 10000*time.Second, duration) |
There was a problem hiding this comment.
Magic value. Could we use const preparing request and testing assertion?
internal/broker/bind_create_test.go
Outdated
|
|
||
| duration, err := getTokenDuration(t, binding.Credentials) | ||
| require.NoError(t, err) | ||
| assert.Equal(t, 900*time.Second, duration) |
There was a problem hiding this comment.
Magic value again. As in the previous comment.
KsaweryZietara
changed the title
KsaweryZietara
force-pushed
the
add-token-expiration-to-binding-params
branch
3 times, most recently
from
a5a06f1 to
1177215
Compare
IwonaLanger
reviewed
Sep 26, 2024
IwonaLanger
previously approved these changes
Sep 26, 2024
KsaweryZietara
force-pushed
the
add-token-expiration-to-binding-params
branch
2 times, most recently
from
e95a757 to
3fd7c40
Compare
KsaweryZietara
force-pushed
the
add-token-expiration-to-binding-params
branch
from
3fd7c40 to
b2ba57d
Compare
ralikio
approved these changes
Oct 2, 2024
KsaweryZietara
removed
the
do-not-merge/hold
IwonaLanger
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
expiration_secondsparameter if specified, otherwise use value from KEB config,Related issue(s)
See also #284