Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKR tester: assert command #1616

Merged
merged 12 commits into from
Jan 14, 2025
Merged

SKR tester: assert command #1616

merged 12 commits into from
Jan 14, 2025

Conversation

MarekMichali
Copy link
Contributor

@MarekMichali MarekMichali commented Jan 9, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • Add the ability to connect to the SKR with a kubeconfig from kcp cli
  • Assert OIDC config on SKR
  • Assert OIDC config in public kubeconfig
  • Assert machine type
  • Assert administrators on SKR

Related issue(s)

See #1588

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. labels Jan 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 9, 2025
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 9, 2025
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 9, 2025
@MarekMichali MarekMichali marked this pull request as ready for review January 13, 2025 06:08
@MarekMichali MarekMichali requested a review from a team as a code owner January 13, 2025 06:08
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2025
@MarekMichali
Copy link
Contributor Author

/kind enhancement

@kyma-bot kyma-bot added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Jan 13, 2025
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) January 13, 2025 06:09
@MarekMichali MarekMichali self-assigned this Jan 14, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 14, 2025
@kyma-gopher-bot kyma-gopher-bot merged commit ebd8a09 into kyma-project:main Jan 14, 2025
53 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@MarekMichali MarekMichali

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarekMichali @jaroslaw-pieszka @kyma-bot @kyma-gopher-bot