Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label app.kubernetes.io/instance #1679

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

TorstenD-SAP
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Add the label app.kubernetes.io/instance: kcp to runtime-reconciler
  • Add the label app.kubernetes.io/instance: kcp to subaccount-sync

Related issue(s)

@TorstenD-SAP TorstenD-SAP requested a review from a team as a code owner January 24, 2025 13:18
@CLAassistant
Copy link

CLAassistant commented Jan 24, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) January 24, 2025 13:18
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 24, 2025
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 24, 2025
@TorstenD-SAP TorstenD-SAP added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Jan 24, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 24, 2025
@kyma-gopher-bot kyma-gopher-bot merged commit bb783d4 into main Jan 24, 2025
28 of 34 checks passed
@MarekMichali MarekMichali deleted the add-instance-label branch January 24, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants