Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HAP step retries #1705

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Fix HAP step retries #1705

merged 2 commits into from
Feb 3, 2025

Conversation

piotrmiskiewicz
Copy link
Member

@piotrmiskiewicz piotrmiskiewicz commented Feb 3, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • use OperationManage.RetryOperation for retries in the resolve credentials step
  • make timeout smaller for the step

Related issue(s)
Resolves: #1706

@piotrmiskiewicz piotrmiskiewicz requested a review from a team as a code owner February 3, 2025 09:47
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) February 3, 2025 09:47
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 3, 2025
@piotrmiskiewicz piotrmiskiewicz added the kind/bug Categorizes issue or PR as related to a bug. label Feb 3, 2025
@kyma-gopher-bot kyma-gopher-bot merged commit d975362 into kyma-project:main Feb 3, 2025
32 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hyperscaler Account Pool step neverending retries
4 participants
@piotrmiskiewicz @jaroslaw-pieszka @kyma-bot @kyma-gopher-bot