Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert workers and additional workers on runtimes endpoint #1708

Merged
merged 7 commits into from
Feb 4, 2025
Merged

Assert workers and additional workers on runtimes endpoint #1708

merged 7 commits into from
Feb 4, 2025
+36 −0

Conversation

jaroslaw-pieszka
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Assert that workers and additionalWorkers are present in runtime configuration (runtime_config parameter) returned by /runtimes endpoint

Related issue(s)

@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner February 4, 2025 10:07
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Feb 4, 2025
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. labels Feb 4, 2025
@jaroslaw-pieszka jaroslaw-pieszka added kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature and removed cla: yes Indicates the PR's author has signed the CLA. labels Feb 4, 2025
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) February 4, 2025 10:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 4, 2025
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 4, 2025
@ralikio ralikio added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 4, 2025
szwedm
szwedm approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jaroslaw-pieszka jaroslaw-pieszka removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2025
@kyma-gopher-bot kyma-gopher-bot merged commit 04374d4 into kyma-project:main Feb 4, 2025
27 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szwedm szwedm szwedm approved these changes

@ralikio ralikio ralikio approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@szwedm szwedm

@ralikio ralikio

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jaroslaw-pieszka @szwedm @ralikio @kyma-bot @kyma-gopher-bot