Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More logs to Discover Flakiness #1712

Merged
merged 3 commits into from
Feb 5, 2025
Merged

More logs to Discover Flakiness #1712

merged 3 commits into from
Feb 5, 2025

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Feb 5, 2025

Description

Changes proposed in this pull request:

  • added missing instanceId field in runtime reconciler logger to clearly know when an instance has its secret recreated and when it is updated,
  • added logs to skr-test to make sure that the secret has not been updated before the wait logic has a chance to run.

Related issue(s)

@ralikio ralikio added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Feb 5, 2025
@ralikio ralikio self-assigned this Feb 5, 2025
@ralikio ralikio requested a review from a team as a code owner February 5, 2025 11:58
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 5, 2025
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) February 5, 2025 11:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 5, 2025
@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 5, 2025
@kyma-gopher-bot kyma-gopher-bot merged commit a31aa6e into main Feb 5, 2025
31 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@ralikio ralikio

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ralikio @jaroslaw-pieszka @kyma-bot @kyma-gopher-bot