Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove component documents #18466

Merged
merged 6 commits into from
Dec 8, 2023
Merged

Remove component documents #18466

merged 6 commits into from
Dec 8, 2023

Conversation

mmitoraj
Copy link
Contributor

@mmitoraj mmitoraj commented Dec 7, 2023

Description

Changes proposed in this pull request:

  • Cleaned up components' leftovers

Related issue(s)
#18455

@mmitoraj mmitoraj added the area/documentation Issues or PRs related to documentation label Dec 7, 2023
@mmitoraj mmitoraj requested a review from a team as a code owner December 7, 2023 13:02
Copy link

netlify bot commented Dec 7, 2023

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 941236a

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 941236a
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/65731a858d626c00086ce064
😎 Deploy Preview https://deploy-preview-18466--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 7, 2023
@@ -1,206 +0,0 @@
---
title: Back up Kyma
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that document covered somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have that general document -> https://help.sap.com/docs/btp/sap-business-technology-platform/kyma-environment-backup?version=Cloud. Let's enrich it with the details we want to remove. I'm leaving the doc for the time being. Issue created.

@@ -1,23 +0,0 @@
---
title: Access Kyma application logs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that document covered somewhere?

Copy link
Contributor Author

@mmitoraj mmitoraj Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue created to add the content to the HP -> https://github.tools.sap/kyma/backlog/issues/4814. I'm leaving the doc for the time being.

@mmitoraj mmitoraj added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/missing-docs-review Indicates that a PR should not merge beacuse it has missing documentation review. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 8, 2023
a-thaler
a-thaler previously approved these changes Dec 8, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 8, 2023
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 8, 2023

### Verify the installation
2. Choose a module and deploy its module manager and apply the module configuration. The operation installs a Kyma module of your choice on a Kubernetes cluster. See the already available Kyma modules with their quick installation steps and links to their GitHub repositories:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Choose a module and deploy its module manager and apply the module configuration. The operation installs a Kyma module of your choice on a Kubernetes cluster. See the already available Kyma modules with their quick installation steps and links to their GitHub repositories:
2. Choose a module, deploy its module manager, and apply the module configuration. The operation installs a Kyma module of your choice on a Kubernetes cluster. See the already available Kyma modules with their quick installation steps and links to their GitHub repositories:

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 8, 2023
@kyma-bot kyma-bot merged commit c3326dc into kyma-project:main Dec 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. do-not-merge/missing-docs-review Indicates that a PR should not merge beacuse it has missing documentation review. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants