Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove new lines from generated CRD description #18627

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

chrkl
Copy link
Contributor

@chrkl chrkl commented Mar 25, 2024

Description

Recent controller-gen versions introduced line breaks in CRD field descriptions. This change breaks the generated markdown tables by table-gen. This change replaces all line breaks by spaces in the description fields.

Changes proposed in this pull request:

  • Remove new lines from generated CRD description

Related issue(s)

kyma-project/telemetry-manager#900

@chrkl chrkl requested review from k15r and a team as code owners March 25, 2024 12:08
Copy link

netlify bot commented Mar 25, 2024

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 16b2427

@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 25, 2024
Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 16b2427
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/66016926f56ddc0008b1dc42
😎 Deploy Preview https://deploy-preview-18627--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 25, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 26, 2024
@kyma-bot kyma-bot merged commit fb4e2ca into kyma-project:main Mar 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants