Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove moved code #18707

Merged
merged 4 commits into from
Jun 27, 2024
Merged

Remove moved code #18707

merged 4 commits into from
Jun 27, 2024

Conversation

VOID404
Copy link
Contributor

@VOID404 VOID404 commented Jun 11, 2024

Description

Changes proposed in this pull request:

  • ...
  • ...
  • ...

Related issue(s)

kyma-project/application-connector-manager#267

@VOID404 VOID404 requested review from a team as code owners June 11, 2024 06:55
@netlify Netlify
Copy link

netlify bot commented Jun 11, 2024 •
edited
Loading

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f71dd15

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 11, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 11, 2024 •
edited
Loading

✅ Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit f71dd15
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/667d20bb4ecd530008112f12
😎 Deploy Preview https://deploy-preview-18707--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

m00g3n
m00g3n previously approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 11, 2024
grego952
grego952 previously approved these changes Jun 11, 2024
View reviewed changes
@a-thaler
Copy link
Contributor

As you are the last one in the folders, could you please directly remove these folder:

  • resources
  • components
  • tests
  • installation

Thanks a lot

@VOID404 VOID404 dismissed stale reviews from grego952 and m00g3n via 02c93ee June 12, 2024 10:30
@VOID404 VOID404 requested a review from a team as a code owner June 12, 2024 10:30
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jun 12, 2024
@kyma-bot
Copy link
Contributor

@VOID404: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-validate-dockerfiles 02c93ee link true /test pre-main-kyma-validate-dockerfiles
pull-central-application-connectivity-validator-lint 02c93ee link false /test pull-central-application-connectivity-validator-lint
pull-application-connector-compass-runtime-agent-test-build 02c93ee link false /test pull-application-connector-compass-runtime-agent-test-build
pull-application-connector-connectivity-validator-test-build 02c93ee link false /test pull-application-connector-connectivity-validator-test-build
pull-application-connector-gateway-test-build 02c93ee link false /test pull-application-connector-gateway-test-build
pull-central-application-gateway-lint 02c93ee link false /test pull-central-application-gateway-lint
pull-application-connector-mock-app-build 02c93ee link false /test pull-application-connector-mock-app-build
pull-compass-runtime-agent-lint 02c93ee link false /test pull-compass-runtime-agent-lint
pre-main-kyma-validate-image-existence 02c93ee link false /test pre-main-kyma-validate-image-existence
pre-main-kyma-validate-image-definitions 02c93ee link false /test pre-main-kyma-validate-image-definitions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 12, 2024
@VOID404 VOID404 requested review from grego952 and m00g3n June 13, 2024 05:07
m00g3n
m00g3n approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Jun 24, 2024
Merged
Merged
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jun 27, 2024
Disper
Disper approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@Disper Disper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 27, 2024
@kyma-bot kyma-bot merged commit d680aba into kyma-project:main Jun 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grego952 grego952 grego952 approved these changes

@jeremyharisch jeremyharisch jeremyharisch approved these changes

@m00g3n m00g3n m00g3n approved these changes

@a-thaler a-thaler a-thaler approved these changes

@Disper Disper Disper approved these changes

Assignees

@Disper Disper

@a-thaler a-thaler

@m00g3n m00g3n

@jeremyharisch jeremyharisch

@grego952 grego952

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@VOID404 @a-thaler @kyma-bot @Disper @m00g3n @jeremyharisch @grego952