Code review comments

kyma-project · Jul 4, 2024 · 3e1cd49 · 3e1cd49
1 parent 00a8725
commit 3e1cd49
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/api/v1beta2/manifest_types.go b/api/v1beta2/manifest_types.go
@@ -65,6 +65,7 @@ type ManifestSpec struct {
 
 	// ManagedResources specifies a list of resources which are managed
 	// manually by the user. The resources have the following format: <group>/<version>/<kind>.
+	// +optional
 	ManagedResources []string `json:"managedResources,omitempty"`
 }
 

diff --git a/docs/technical-reference/api/manifest-cr.md b/docs/technical-reference/api/manifest-cr.md
@@ -88,7 +88,7 @@ The resource is the default data that should be initialized for the module and i
 ### **.spec.managedResources**
 
 The managedResources are the resources which are managed manually by the user. They are represented by the `group/version/kind` format. 
-If the module is managed and gets deleted from the Kyma CR, module resources remain undeleted until all custom resources with GVK listed in the spec.managedResources are removed manually by the user.   
+If the module is managed and gets deleted from the Kyma CR, module deletion is suspended until all custom resources with GVK listed in the spec.managedResources are removed manually by the user.   
 ```yaml
 spec:
   managedResources: