Skip to content

Commit

Permalink
Renaming ManagedResources to AssociatedResources
Browse files Browse the repository at this point in the history
  • Loading branch information
nesmabadr committed Jul 8, 2024
1 parent 09259b5 commit 8f33428
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 22 deletions.
6 changes: 3 additions & 3 deletions api/v1beta2/manifest_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ type ManifestSpec struct {
// Resource specifies a resource to be watched for state updates
Resource *unstructured.Unstructured `json:"resource,omitempty"`

// ManagedResources specifies a list of resources which are managed
// manually by the user. The resources have the following format: <group>/<version>/<kind>.
// AssociatedResources specifies a list of resources which are not managed
// by the lifecycle manager. The resources have the following format: <group>/<version>/<kind>.
// +optional
ManagedResources []string `json:"managedResources,omitempty"`
AssociatedResources []string `json:"associatedResources,omitempty"`
}

// ImageSpec defines OCI Image specifications.
Expand Down
4 changes: 2 additions & 2 deletions api/v1beta2/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 14 additions & 14 deletions config/crd/bases/operator.kyma-project.io_manifests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,13 @@ spec:
spec:
description: ManifestSpec defines the desired state of Manifest.
properties:
associatedResources:
description: |-
AssociatedResources specifies a list of resources which are not managed
by the lifecycle manager. The resources have the following format: <group>/<version>/<kind>.
items:
type: string
type: array
config:
description: Config specifies OCI image configuration for Manifest
properties:
Expand Down Expand Up @@ -136,13 +143,6 @@ spec:
- name
- source
type: object
managedResources:
description: |-
ManagedResources specifies a list of resources which are managed
manually by the user. The resources have the following format: <group>/<version>/<kind>.
items:
type: string
type: array
remote:
description: Remote indicates if Manifest should be installed on a
remote cluster
Expand Down Expand Up @@ -326,6 +326,13 @@ spec:
spec:
description: ManifestSpec defines the desired state of Manifest.
properties:
associatedResources:
description: |-
AssociatedResources specifies a list of resources which are not managed
by the lifecycle manager. The resources have the following format: <group>/<version>/<kind>.
items:
type: string
type: array
config:
description: Config specifies OCI image configuration for Manifest
properties:
Expand Down Expand Up @@ -413,13 +420,6 @@ spec:
- name
- source
type: object
managedResources:
description: |-
ManagedResources specifies a list of resources which are managed
manually by the user. The resources have the following format: <group>/<version>/<kind>.
items:
type: string
type: array
remote:
description: Remote indicates if Manifest should be installed on a
remote cluster
Expand Down
6 changes: 3 additions & 3 deletions docs/technical-reference/api/manifest-cr.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,13 +85,13 @@ The [internal spec resolver](../../../internal/manifest/spec_resolver.go) uses t

The resource is the default data that should be initialized for the module and is directly copied from **.spec.data** of the ModuleTemplate CR after normalizing it with the **namespace** for the synchronized module.

### **.spec.managedResources**
### **.spec.associatedResources**

The managed resources are the resources that are handled manually by the user. They are represented by the `group/version/kind` format.
The associated resources are the resources that are not managed by the lifecycle manager. They are represented by the `group/version/kind` format.
Suppose the module is managed and gets deleted from the Kyma CR. In that case, the module deletion is suspended until all custom resources with GVK listed in the **spec.managedResources** are removed manually by the user.
```yaml
spec:
managedResources:
associatedResources:
- serverless.kyma-project.io/v1alpha2/functions
- operator.kyma-project.io/v1alpha1/serverlesses
```
Expand Down

0 comments on commit 8f33428

Please sign in to comment.