-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Trigger warning for PRs likely requiring updates to management-plane-charts #2219
Open
medmes
wants to merge
31
commits into
kyma-project:main
Choose a base branch
from
medmes:trigger_warning_job_on_pr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
Indicates the PR's author has signed the CLA.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Jan 30, 2025
medmes
changed the title
Trigger warning for PRs likely requiring updates to management-plane-charts
feat: Trigger warning for PRs likely requiring updates to management-plane-charts
Jan 30, 2025
kyma-bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Jan 30, 2025
kyma-bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Jan 30, 2025
kyma-bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Jan 30, 2025
kyma-bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Jan 30, 2025
This reverts commit 6d15458.
kyma-bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Jan 30, 2025
2 tasks
c-pius
requested changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just some general suggestions:
- I think I would split this into two workflows, one verifying that manifests are up to date, one checking if there are relevant changes
- regarding the config changes, I think it would be more robust if we work on the actual output based on the configuration
- so instead of checking if there are changes on the config files, I would suggest that we generate the KLM manifests from PR and main and compare if there are changes
- we already did this in an earlier implementation that can be used as a base again: chore: Verify diff in manifests #1358
- the previous point will cover the configuration part, but the ticket also says that the e2e test files are relevant. Here I don't think that we have output to work on, so an approach where we just look if there is a diff in the files should be sufficient. The GH
actions
andscripts
part should be the most relevant. Also, on top level thescripts/tests
part should be included in the check. - I personally prefer consistency in approaches whenever possible. Here, we have multiple cases where we share info between different steps. First, we use the
outputs
of the previous steps, later, we use env variables. I would suggest to consistently useoutputs
in this case.
…trigger_warning_job_on_pr
…er_warning_job_on_pr
…trigger_warning_job_on_pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduce a Github wokflow for detecting changes on the config directory which needs to be reflected into management-plane-chart repository.
Changes proposed in this pull request:
The PR was tested against this Upsttream PR in order to bypass permission complexity:
#2223
For the PR merger
After the Pull request is merged. Please delete the trigger_warning_job_on_pr branch from the upstream.
Related issue(s)
#2089