Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set commonLabels managed-by flag #1425

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Set commonLabels managed-by flag #1425

merged 3 commits into from
Feb 3, 2025

Conversation

pPrecel
Copy link
Contributor

@pPrecel pPrecel commented Jan 31, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • allow using dots while setting flags
  • set managed-by label for all serverless resources

Related issue(s)

@pPrecel pPrecel added area/serverless Issues or PRs related to serverless kind/chore Categorizes issue or PR as related to a chore. labels Jan 31, 2025
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 31, 2025
@pPrecel pPrecel force-pushed the label-ALL-serverless-resources branch from 1f0d59f to 0cac08b Compare January 31, 2025 08:08
@pPrecel pPrecel changed the title set commonLabels managed-by flag Set commonLabels managed-by flag Jan 31, 2025
@pPrecel pPrecel force-pushed the label-ALL-serverless-resources branch from 0cac08b to 03b69ba Compare January 31, 2025 08:09
@pPrecel pPrecel marked this pull request as ready for review January 31, 2025 08:09
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2025
@pPrecel pPrecel force-pushed the label-ALL-serverless-resources branch from ec35304 to a97e39f Compare January 31, 2025 15:22
@pPrecel pPrecel enabled auto-merge (squash) January 31, 2025 15:23
@pPrecel pPrecel force-pushed the label-ALL-serverless-resources branch from a97e39f to ac6849e Compare February 2, 2025 19:08
@pPrecel pPrecel force-pushed the label-ALL-serverless-resources branch from ac6849e to d3f945b Compare February 2, 2025 20:52
@pPrecel pPrecel merged commit 070aa04 into kyma-project:main Feb 3, 2025
21 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halamix2 halamix2 halamix2 approved these changes

@kwiatekus kwiatekus Awaiting requested review from kwiatekus kwiatekus is a code owner

@Cortey Cortey Awaiting requested review from Cortey Cortey is a code owner

@anoipm anoipm Awaiting requested review from anoipm anoipm is a code owner

@MichalKalke MichalKalke Awaiting requested review from MichalKalke MichalKalke is a code owner

Assignees

@halamix2 halamix2

Labels
area/serverless Issues or PRs related to serverless cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pPrecel @halamix2 @kyma-bot