Skip to content

Commit

Permalink
adjust DeleteResources for log gateway to use istioStatusChecker
Browse files Browse the repository at this point in the history
  • Loading branch information
shorim committed Dec 10, 2024
1 parent 0b9f08b commit 01dc967
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions internal/reconciler/logpipeline/otel/reconciler.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,7 @@ func (r *Reconciler) doReconcile(ctx context.Context, pipeline *telemetryv1alpha
if len(reconcilablePipelines) == 0 {
logf.FromContext(ctx).V(1).Info("cleaning up log pipeline resources: all log pipelines are non-reconcilable")

// TODO: Set 'false' to 'r.istioStatusChecker.IsIstioActive(ctx)' istio is implemented for this type of pipeline
if err = r.gatewayApplierDeleter.DeleteResources(ctx, r.Client, false); err != nil {
if err = r.gatewayApplierDeleter.DeleteResources(ctx, r.Client, r.istioStatusChecker.IsIstioActive(ctx)); err != nil {
return fmt.Errorf("failed to delete gateway resources: %w", err)
}

Expand Down

0 comments on commit 01dc967

Please sign in to comment.