Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add conversion webhook config to dev CRD variant #1463

Merged

Conversation

skhalash
Copy link
Collaborator

@skhalash skhalash commented Sep 19, 2024

Description

Changes proposed in this pull request (what was done and why):

  • Add a conversion webhook that convert between v1alpha1 and v1beta1 LogPipelines. The only difference in the schema: an application input in v1alpha1 vs a runtime input. This functionality is hidden behind the feature flag enable-v1beta1-log-pipelines
  • Adjust the names of v1beta1 LogPipeline spec subtypes - add a LogPipeline prefix similar to MetricPipeline and TracePipeline
  • Remove unneeded certmanager patches in kustomize: cainjection_in_*
  • Refactor creating ValidatingWebhookConfiguration to make the linter happy

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 19, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 22, 2024
@skhalash skhalash added area/logs LogPipeline kind/feature Categorizes issue or PR as related to a new feature. labels Sep 23, 2024
@skhalash skhalash added this to the 1.25.0 milestone Sep 25, 2024
@skhalash skhalash marked this pull request as ready for review September 25, 2024 18:54
@skhalash skhalash requested a review from a team as a code owner September 25, 2024 18:54
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 27, 2024
@kyma-bot kyma-bot merged commit ab08df3 into kyma-project:main Sep 27, 2024
46 checks passed
@skhalash skhalash deleted the logpipeline-add-conversion-webhook branch September 27, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logs LogPipeline cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants