Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix checkmarx findings for sample-app #1761

Merged
merged 2 commits into from
Jan 17, 2025
Merged

docs: Fix checkmarx findings for sample-app #1761

merged 2 commits into from
Jan 17, 2025

Conversation

a-thaler
Copy link
Collaborator

Description

Changes proposed in this pull request (what was done and why):

  • Fixed error handling in sample-app

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@a-thaler a-thaler added area/documentation Documentation changes kind/docs Categorizes issue or PR as related to a documentation change labels Jan 17, 2025
@a-thaler a-thaler added this to the 1.32.0 milestone Jan 17, 2025
@a-thaler a-thaler requested a review from a team as a code owner January 17, 2025 14:31
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 17, 2025
@skhalash skhalash enabled auto-merge (squash) January 17, 2025 15:56
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 17, 2025
@skhalash skhalash merged commit 84e2e70 into kyma-project:main Jan 17, 2025
16 checks passed
@a-thaler a-thaler deleted the sample branch January 20, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skhalash skhalash skhalash approved these changes

Assignees

@skhalash skhalash

Labels
area/documentation Documentation changes cla: yes Indicates the PR's author has signed the CLA. kind/docs Categorizes issue or PR as related to a documentation change lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.32.0
Development

Successfully merging this pull request may close these issues.
3 participants
@a-thaler @skhalash @kyma-bot