Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add cloud provider info to the gateways #1778

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

hisarbalik
Copy link
Contributor

@hisarbalik hisarbalik commented Jan 21, 2025

Description

Changes proposed in this pull request (what was done and why):

  • Add configuration to the k8sattribute processor of gateways (metric, trace, and log) to enrich telemetry data with cloud.availability_zone, cloud.region, host.arch, and host.type from well-known kubernetes labels of nodes
  • Add configuration to the resource processor insert-cluster-attributes of gateways (metric, trace, and log) to enrich telemetry data with k8s.cluster.name and cloud.provider. The data of both were retrieved from custom ConfigMap shoot-info of gardener clusters, for other runtimes, the attribute cloud.provider ignored, and the value of attribute k8s.cluster.name fall-back to the API-Server URL

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@hisarbalik hisarbalik requested a review from a team as a code owner January 21, 2025 12:29
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 21, 2025
@hisarbalik hisarbalik added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed cla: yes Indicates the PR's author has signed the CLA. labels Jan 21, 2025
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 21, 2025
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 22, 2025
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 22, 2025
internal/utils/k8s/cluster_info_getter.go Outdated Show resolved Hide resolved
sec-scanners-config.yaml Outdated Show resolved Hide resolved
config/rbac/role.yaml Outdated Show resolved Hide resolved
@@ -51,5 +51,15 @@ func extractLabels() []config.ExtractLabel {
Key: "app",
TagName: "kyma.app_name",
},
{
From: "node",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we know in case of k3d how this works ? will it be left empty ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for k3d and any cluster that doesn't use the labels on nodes, the attributes will not be present on the telemetry data being processed

internal/utils/k8s/cluster_info_getter.go Outdated Show resolved Hide resolved
@hisarbalik hisarbalik requested a review from a team as a code owner January 22, 2025 14:27
@hisarbalik hisarbalik added this to the 1.33.0 milestone Jan 22, 2025
@hisarbalik hisarbalik added kind/feature Categorizes issue or PR as related to a new feature. area/tests Writing/adding/Refactoring tests or checks area/logs LogPipeline area/metrics MetricPipeline area/traces TracePipeline area/manager Manager or module changes labels Jan 22, 2025
@hisarbalik hisarbalik removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logs LogPipeline area/manager Manager or module changes area/metrics MetricPipeline area/tests Writing/adding/Refactoring tests or checks area/traces TracePipeline cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants