-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add cloud provider info to the gateways #1778
base: main
Are you sure you want to change the base?
feat: Add cloud provider info to the gateways #1778
Conversation
@@ -51,5 +51,15 @@ func extractLabels() []config.ExtractLabel { | |||
Key: "app", | |||
TagName: "kyma.app_name", | |||
}, | |||
{ | |||
From: "node", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we know in case of k3d how this works ? will it be left empty ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for k3d and any cluster that doesn't use the labels on nodes, the attributes will not be present on the telemetry data being processed
….com:hisarbalik/telemetry-manager into add-metricpipeline-cloud-provider-attributes
Description
Changes proposed in this pull request (what was done and why):
k8sattribute
processor of gateways (metric, trace, and log) to enrich telemetry data withcloud.availability_zone
,cloud.region
,host.arch
, andhost.type
from well-known kubernetes labels of nodesresource
processorinsert-cluster-attributes
of gateways (metric, trace, and log) to enrich telemetry data withk8s.cluster.name
andcloud.provider
. The data of both were retrieved from custom ConfigMapshoot-info
of gardener clusters, for other runtimes, the attributecloud.provider
ignored, and the value of attributek8s.cluster.name
fall-back to the API-Server URLChanges refer to particular issues, PRs or documents:
Traceability
Related Issues
section.