Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove unnecessary kube-rbac-proxy reference #1790

Merged
merged 3 commits into from
Jan 28, 2025
Merged

chore: Remove unnecessary kube-rbac-proxy reference #1790

merged 3 commits into from
Jan 28, 2025

Conversation

k15r
Copy link
Contributor

@k15r k15r commented Jan 28, 2025

Description

Changes proposed in this pull request (what was done and why):

  • kube-rbac-proxy was not used, but still referenced in an unused file

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@k15r k15r requested a review from a team as a code owner January 28, 2025 10:21
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 28, 2025
@k15r k15r changed the title chore: Remove unnecessary ube-rbac-proxy reference chore: Remove unnecessary kube-rbac-proxy reference Jan 28, 2025
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 28, 2025
@k15r k15r added area/dependency Dependency changes kind/chore Categorizes issue or PR as related to a chore. labels Jan 28, 2025
@k15r k15r added this to the 1.33.0 milestone Jan 28, 2025
@k15r k15r enabled auto-merge (squash) January 28, 2025 12:12
@k15r k15r merged commit c87a9d4 into kyma-project:main Jan 28, 2025
41 of 43 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skhalash skhalash skhalash approved these changes

Assignees

@skhalash skhalash

Labels
area/dependency Dependency changes cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.33.0
Development

Successfully merging this pull request may close these issues.
3 participants
@k15r @skhalash @kyma-bot