generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Simplify Makefile Architecture #832
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
Indicates the PR's author has signed the CLA.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Feb 28, 2024
NHingerl
reviewed
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
If this were user
documentation, I'd ask you to adjust the diagrams to match our guidelines. However, I seem to be turning soft with age and I'll just ask you to familiarize yourself with the Kyma diagram guidelines for future diagram draftsmanship.
Co-authored-by: Nina Hingerl <[email protected]>
Co-authored-by: Nina Hingerl <[email protected]>
Co-authored-by: Nina Hingerl <[email protected]>
Co-authored-by: Nina Hingerl <[email protected]>
Co-authored-by: Nina Hingerl <[email protected]>
Co-authored-by: Nina Hingerl <[email protected]>
Co-authored-by: Nina Hingerl <[email protected]>
Co-authored-by: Nina Hingerl <[email protected]>
Co-authored-by: Nina Hingerl <[email protected]>
Co-authored-by: Nina Hingerl <[email protected]>
NHingerl
previously approved these changes
Feb 29, 2024
shorim
reviewed
Mar 5, 2024
shorim
reviewed
Mar 5, 2024
shorim
reviewed
Mar 5, 2024
shorim
reviewed
Mar 5, 2024
shorim
reviewed
Mar 5, 2024
shorim
reviewed
Mar 5, 2024
shorim
reviewed
Mar 6, 2024
shorim
approved these changes
Mar 6, 2024
NHingerl
approved these changes
Mar 7, 2024
8 tasks
a-thaler
added
area/ci
Changes to GithubActions
kind/chore
Categorizes issue or PR as related to a chore.
labels
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/ci
Changes to GithubActions
cla: yes
Indicates the PR's author has signed the CLA.
kind/chore
Categorizes issue or PR as related to a chore.
lgtm
Looks good to me!
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request (what was done and why):
provision.mk
anddependencies.mk
)Changes refer to particular issues, PRs or documents:
Traceability
area
andkind
label.Related Issues
section.