fix: Ensure pending condition is always preserved #887
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request (what was done and why):
Pending
condition always exists in the conditions list forTracePipeline
,LogPipeline
andLogParser
Trace Gateway
/Fluent Bit
to restart. Therefore, when handling the running condition, we can always set the reason for the false pending condition to beFluentBitDaemonSetNotReady
forLogPipeline
andTraceGatewayDeploymentNotReady
forTracePipeline
SetRunningCondition
func toHandleRunningCondition
to avoid giving the false impression that it only sets theRunning
condition to TrueSetPendingCondition
func toHandlePendingCondition
to avoid giving the false impression that it only sets thePending
condition to TrueChanges refer to particular issues, PRs or documents:
Traceability
area
andkind
label.Related Issues
section.