Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure pending condition is always preserved #887

Merged

Conversation

shorim
Copy link
Contributor

@shorim shorim commented Mar 14, 2024

Description

Changes proposed in this pull request (what was done and why):

  • Ensure that the Pending condition always exists in the conditions list for TracePipeline, LogPipeline and LogParser
  • If a pipeline was in a pending condition and then it becomes deployable, this will result in the Trace Gateway / Fluent Bit to restart. Therefore, when handling the running condition, we can always set the reason for the false pending condition to be FluentBitDaemonSetNotReady for LogPipeline and TraceGatewayDeploymentNotReady for TracePipeline
  • Rename SetRunningCondition func to HandleRunningCondition to avoid giving the false impression that it only sets the Running condition to True
  • Rename SetPendingCondition func to HandlePendingCondition to avoid giving the false impression that it only sets the Pending condition to True
  • Updated unit tests
  • Updated e2e test verifiers

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@shorim shorim requested a review from a team as a code owner March 14, 2024 05:15
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 14, 2024
@shorim shorim added kind/bug Categorizes issue or PR as related to a bug. area/manager Manager or module changes labels Mar 14, 2024
@shorim shorim added this to the 1.11.1 milestone Mar 14, 2024
@shorim shorim changed the title fix: Ensure pending condition is preserved fix: Ensure pending condition is always preserved Mar 14, 2024
@skhalash skhalash self-assigned this Mar 14, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 14, 2024
@kyma-bot kyma-bot merged commit 6ef6e90 into kyma-project:main Mar 14, 2024
25 checks passed
hisarbalik pushed a commit to hisarbalik/telemetry-manager that referenced this pull request Mar 14, 2024
hisarbalik pushed a commit to hisarbalik/telemetry-manager that referenced this pull request Mar 14, 2024
@a-thaler a-thaler modified the milestones: 1.11.1, 1.12.0 Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/manager Manager or module changes cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants