Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add basic e2e tests for v1beta1 version #893

Merged
merged 35 commits into from
Mar 15, 2024
Merged

test: Add basic e2e tests for v1beta1 version #893

merged 35 commits into from
Mar 15, 2024

Conversation

shorim
Copy link
Contributor

@shorim shorim commented Mar 14, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Rename existing builders in testkit to make it clear that they are responsible for building pipelines in version v1alpha1: LogPipeline, MetricPipeline and TracePipeline were renamed to logPipelineV1Alpha1, metricPipelineV1Alpha1 and tracePipelineV1Alpha1 respectively
  • Add new builders in testkit for v1beta1 version: logPipelineV1Beta1, metricPipelineV1Beta1 and tracePipelineV1Alpha1
  • Add new e2e basic tests based on v1beta1 version for logs, traces and metrics.
  • The new v1beta1 e2e tests have 2 ginkgo labels: v1beta1 and the usual domain label (metrics or traces or logs)
  • Exclude the new v1beta1 tests from being executed in the *-release test jobs. The exclusion is achieved using the v1beta1 label. This is needed since in the *-release jobs, only the v1alpha1 CRDs are created

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@shorim shorim added kind/missing-test Categorizes issue or PR as related to missing automated tests for scenario. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/manager Manager or module changes labels Mar 14, 2024
@shorim shorim added this to the 1.12.0 milestone Mar 14, 2024
@shorim shorim requested a review from a team as a code owner March 14, 2024 14:34
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 14, 2024
shorim added 17 commits March 14, 2024 15:48
@shorim
add logs basic test for v1beta1 version
26efab7
@shorim
add telemetryv1beta1 alias in golangci
e439edf
@shorim
add ignore duplication for linting
3ebe5c0
@shorim
change location of nolint for duplication
4022b10
@shorim
add nolint for duplication also in logPipelineV1Alpha1 builder
81b068d
@shorim
add telemetryv1beta1 to scheme in e2e test suite
b1272fa
@shorim
rename logPipelinev1alpha1 to logPipelineV1Alpha1
e09f496
@shorim
rename NewLogPipelinev1alpha1 to NewLogPipelineV1Alpha1
9ca2293
@shorim
rename logPipelinev1beta1 to logPipelineV1Beta1
e6a8f51
@shorim
rename NewLogPipelinev1beta1 to NewLogPipelineV1Beta1
899e32c
@shorim
rename SecretKeyRefv1alpha1 to SecretKeyRefV1Alpha1
eefec5a
@shorim
rename SecretKeyRefv1beta1 to SecretKeyRefV1Beta1
1005b75
@shorim
rename HostSecretRefv1alpha1 to HostSecretRefV1Alpha1
e511c1b
@shorim
rename HostSecretRefv1beta1 to HostSecretRefV1Beta1
bc1c0d7
@shorim
setup label-filter in GitHub actions
d00a963
@shorim
rename TracePipeline to tracePipelineV1Alpha1 in testkit
c4e7cf7
@shorim
rename NewTracePipeline to NewTracePipelineV1Alpha1
ca90f39
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 14, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 14, 2024
@shorim shorim removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2024
@shorim shorim changed the title test: Add basic e2e test for v1beta1 version test: Add basic e2e tests for v1beta1 version Mar 15, 2024
@skhalash skhalash self-assigned this Mar 15, 2024
skhalash
skhalash requested changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@skhalash skhalash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few comments

test/e2e/logs_basic_v1beta1_test.go Outdated Show resolved Hide resolved
test/e2e/metrics_basic_v1beta1_test.go Outdated Show resolved Hide resolved
test/e2e/traces_basic_v1beta1_test.go Outdated Show resolved Hide resolved
skhalash
skhalash previously approved these changes Mar 15, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 15, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Mar 15, 2024
@shorim
Copy link
Contributor Author

shorim commented Mar 15, 2024

/test pull-telemetry-manager-build

2 similar comments
@shorim
Copy link
Contributor Author

shorim commented Mar 15, 2024

/test pull-telemetry-manager-build

@shorim
Copy link
Contributor Author

shorim commented Mar 15, 2024

/test pull-telemetry-manager-build

@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 15, 2024
@kyma-bot kyma-bot merged commit da09632 into kyma-project:main Mar 15, 2024
28 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skhalash skhalash skhalash approved these changes

Assignees

@skhalash skhalash

Labels
area/manager Manager or module changes cla: yes Indicates the PR's author has signed the CLA. kind/missing-test Categorizes issue or PR as related to missing automated tests for scenario. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shorim @skhalash @kyma-bot