Run expiration check with extended time for all tokens #12245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print oidc verifier config in log messages
|
Skipping CI for Draft Pull Request. |
kyma-bot
added
do-not-merge/work-in-progress
… time by default for all tokens. Added options to set expiry check and expiration time values. Verify method runs own expiration check if upstream expiry check is skipped. Added expiration check verification. Applying options only if provided. This allows better logging.
kyma-bot
added
size/L
dekiel
changed the title
kyma-bot
removed
the
do-not-merge/work-in-progress
akiioto
requested changes
Oct 28, 2024
akiioto
approved these changes
Oct 28, 2024
KacperMalachowski
pushed a commit
to KacperMalachowski/test-infra
that referenced
this pull request
Nov 6, 2024
…12245) * Remove unused flags Print oidc verifier config in log messages * Skip expiry check and run expiration check with 10 minutes expiration time by default for all tokens. Added options to set expiry check and expiration time values. Verify method runs own expiration check if upstream expiry check is skipped. Added expiration check verification. Applying options only if provided. This allows better logging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Skip expiry check and run expiration check with 10 minutes expiration time by default for all tokens.
Added options to set expiry check and expiration time values.
Verify method runs own expiration check if upstream expiry check is skipped.
Added expiration check verification.
Applying options only if provided. This allows better logging.
Print oidc verifier config in log messages
Cleanup code comments and unused flags.
Renaming cobra command function to better represent its purpose.