Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status of pushing images to registry #12615

Merged

Conversation

KacperMalachowski
Copy link
Contributor

Description

SRE wants to know whether image was pushed even if overall status is failed, this change adds that information to build report.

Changes proposed in this pull request:

  • Add IsPushed field in the buidl report file

Related issue(s)

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 31, 2025
pkg/imagebuilder/report_test.go Outdated Show resolved Hide resolved
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 31, 2025
@Sawthis Sawthis enabled auto-merge (squash) January 31, 2025 07:41
@Sawthis Sawthis merged commit 33cb402 into kyma-project:main Jan 31, 2025
39 checks passed
@KacperMalachowski KacperMalachowski deleted the add-push-status-to-build-report branch January 31, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants