-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Update testimages as needed" #12622
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0732d42.
KacperMalachowski
requested review from
neighbors-dev-bot and
a team
as code owners
January 31, 2025 11:02
kyma-bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
cla: yes
Indicates the PR's author has signed the CLA.
add-or-update
labels
Jan 31, 2025
Plan Result
Change Result (Click me) # kubectl_manifest.automated_approver["/apis/apps/v1/namespaces/default/deployments/automated-approver"] will be updated in-place
~ resource "kubectl_manifest" "automated_approver" {
id = "/apis/apps/v1/namespaces/default/deployments/automated-approver"
name = "automated-approver"
~ yaml_body = (sensitive value)
~ yaml_body_parsed = <<-EOT
apiVersion: apps/v1
kind: Deployment
metadata:
labels:
app: automated-approver
name: automated-approver
namespace: default
spec:
selector:
matchLabels:
app: automated-approver
template:
metadata:
labels:
app: automated-approver
spec:
containers:
- args:
- --dry-run=false
- --port=8080
- --hmac-secret-file=/etc/webhook/hmac
- --log-level=info
- --github-endpoint=http://ghproxy
- --github-endpoint=https://api.github.com
- --github-token-path=/etc/github/oauth
- --rules-path=/etc/config/rules.yaml
- --wait-for-statuses-timeout=1800
- image: europe-docker.pkg.dev/kyma-project/prod/automated-approver:v20250131-885542fa
+ image: europe-docker.pkg.dev/kyma-project/prod/automated-approver:v20250131-871459a2
imagePullPolicy: Always
name: automated-approver
ports:
- containerPort: 8080
name: http
volumeMounts:
- mountPath: /etc/webhook
name: hmac
readOnly: true
- mountPath: /etc/github
name: oauth
readOnly: true
- mountPath: /etc/config
name: rules
readOnly: true
volumes:
- name: hmac
secret:
secretName: hmac-token
- name: oauth
secret:
secretName: neighbors-dev-bot-github-token
- configMap:
items:
- key: rules
path: rules.yaml
name: automated-approver-rules
name: rules
EOT
# (14 unchanged attributes hidden)
}
# module.cors_proxy.google_cloud_run_service.cors_proxy will be updated in-place
~ resource "google_cloud_run_service" "cors_proxy" {
id = "locations/europe-west3/namespaces/sap-kyma-prow/services/cors-proxy"
name = "cors-proxy"
# (4 unchanged attributes hidden)
~ template {
~ spec {
# (3 unchanged attributes hidden)
~ containers {
~ image = "europe-docker.pkg.dev/kyma-project/prod/cors-proxy:v20250131-885542fa" -> "europe-docker.pkg.dev/kyma-project/prod/cors-proxy:v20250131-871459a2"
# (2 unchanged attributes hidden)
# (6 unchanged blocks hidden)
}
}
# (1 unchanged block hidden)
}
# (2 unchanged blocks hidden)
}
# module.github_webhook_gateway.google_cloud_run_service.github_webhook_gateway will be updated in-place
~ resource "google_cloud_run_service" "github_webhook_gateway" {
id = "locations/europe-west3/namespaces/sap-kyma-prow/services/github-webhook-gateway"
name = "github-webhook-gateway"
# (4 unchanged attributes hidden)
~ template {
~ spec {
# (3 unchanged attributes hidden)
~ containers {
~ image = "europe-docker.pkg.dev/kyma-project/prod/github-webhook-gateway:v20250131-885542fa" -> "europe-docker.pkg.dev/kyma-project/prod/github-webhook-gateway:v20250131-871459a2"
# (2 unchanged attributes hidden)
# (12 unchanged blocks hidden)
}
# (2 unchanged blocks hidden)
}
# (1 unchanged block hidden)
}
# (2 unchanged blocks hidden)
}
# module.secrets_leaks_log_scanner.google_cloud_run_service.gcs_bucket_mover will be updated in-place
~ resource "google_cloud_run_service" "gcs_bucket_mover" {
id = "locations/europe-west3/namespaces/sap-kyma-prow/services/gcs-bucket-mover"
name = "gcs-bucket-mover"
# (4 unchanged attributes hidden)
~ template {
~ spec {
# (3 unchanged attributes hidden)
~ containers {
~ image = "europe-docker.pkg.dev/kyma-project/prod/move-gcs-bucket:v20250131-885542fa" -> "europe-docker.pkg.dev/kyma-project/prod/move-gcs-bucket:v20250131-871459a2"
# (2 unchanged attributes hidden)
# (9 unchanged blocks hidden)
}
}
# (1 unchanged block hidden)
}
# (2 unchanged blocks hidden)
}
# module.secrets_leaks_log_scanner.google_cloud_run_service.github_issue_creator will be updated in-place
~ resource "google_cloud_run_service" "github_issue_creator" {
id = "locations/europe-west3/namespaces/sap-kyma-prow/services/github-issue-creator"
name = "github-issue-creator"
# (4 unchanged attributes hidden)
~ template {
~ spec {
# (3 unchanged attributes hidden)
~ containers {
~ image = "europe-docker.pkg.dev/kyma-project/prod/create-github-issue:v20250131-885542fa" -> "europe-docker.pkg.dev/kyma-project/prod/create-github-issue:v20250131-871459a2"
# (2 unchanged attributes hidden)
# (11 unchanged blocks hidden)
}
# (1 unchanged block hidden)
}
# (1 unchanged block hidden)
}
# (2 unchanged blocks hidden)
}
# module.secrets_leaks_log_scanner.google_cloud_run_service.github_issue_finder will be updated in-place
~ resource "google_cloud_run_service" "github_issue_finder" {
id = "locations/europe-west3/namespaces/sap-kyma-prow/services/github-issue-finder"
name = "github-issue-finder"
# (4 unchanged attributes hidden)
~ template {
~ spec {
# (3 unchanged attributes hidden)
~ containers {
~ image = "europe-docker.pkg.dev/kyma-project/prod/search-github-issue:v20250131-885542fa" -> "europe-docker.pkg.dev/kyma-project/prod/search-github-issue:v20250131-871459a2"
# (2 unchanged attributes hidden)
# (11 unchanged blocks hidden)
}
# (1 unchanged block hidden)
}
# (1 unchanged block hidden)
}
# (2 unchanged blocks hidden)
}
# module.secrets_leaks_log_scanner.google_cloud_run_service.secrets_leak_log_scanner will be updated in-place
~ resource "google_cloud_run_service" "secrets_leak_log_scanner" {
id = "locations/europe-west3/namespaces/sap-kyma-prow/services/secrets-leak-log-scanner"
name = "secrets-leak-log-scanner"
# (4 unchanged attributes hidden)
~ template {
~ spec {
# (3 unchanged attributes hidden)
~ containers {
~ image = "europe-docker.pkg.dev/kyma-project/prod/scan-logs-for-secrets:v20250131-885542fa" -> "europe-docker.pkg.dev/kyma-project/prod/scan-logs-for-secrets:v20250131-871459a2"
# (2 unchanged attributes hidden)
# (7 unchanged blocks hidden)
}
}
# (1 unchanged block hidden)
}
# (2 unchanged blocks hidden)
}
# module.security_dashboard_token.google_cloud_run_service.security_dashboard_token will be updated in-place
~ resource "google_cloud_run_service" "security_dashboard_token" {
id = "locations/europe-west1/namespaces/sap-kyma-prow/services/security-dashboard-token"
name = "security-dashboard-token"
# (4 unchanged attributes hidden)
~ template {
~ spec {
# (3 unchanged attributes hidden)
~ containers {
~ image = "europe-docker.pkg.dev/kyma-project/prod/dashboard-token-proxy:v20250131-885542fa" -> "europe-docker.pkg.dev/kyma-project/prod/dashboard-token-proxy:v20250131-871459a2"
name = "dashboard-token-proxy-1"
# (2 unchanged attributes hidden)
# (6 unchanged blocks hidden)
}
}
# (1 unchanged block hidden)
}
# (2 unchanged blocks hidden)
}
# module.service_account_keys_cleaner.google_cloud_run_service.service_account_keys_cleaner will be updated in-place
~ resource "google_cloud_run_service" "service_account_keys_cleaner" {
id = "locations/europe-west4/namespaces/sap-kyma-prow/services/service-account-keys-cleaner"
name = "service-account-keys-cleaner"
# (4 unchanged attributes hidden)
~ template {
~ spec {
# (3 unchanged attributes hidden)
~ containers {
~ image = "europe-docker.pkg.dev/kyma-project/prod/test-infra/service-account-keys-cleaner:v20250131-885542fa" -> "europe-docker.pkg.dev/kyma-project/prod/test-infra/service-account-keys-cleaner:v20250131-871459a2"
# (2 unchanged attributes hidden)
# (6 unchanged blocks hidden)
}
}
# (1 unchanged block hidden)
}
# (2 unchanged blocks hidden)
}
# module.service_account_keys_rotator.google_cloud_run_service.service_account_keys_rotator will be updated in-place
~ resource "google_cloud_run_service" "service_account_keys_rotator" {
id = "locations/europe-west4/namespaces/sap-kyma-prow/services/service-account-keys-rotator"
name = "service-account-keys-rotator"
# (4 unchanged attributes hidden)
~ template {
~ spec {
# (3 unchanged attributes hidden)
~ containers {
~ image = "europe-docker.pkg.dev/kyma-project/prod/test-infra/rotate-service-account:v20250131-885542fa" -> "europe-docker.pkg.dev/kyma-project/prod/test-infra/rotate-service-account:v20250131-871459a2"
# (2 unchanged attributes hidden)
# (6 unchanged blocks hidden)
}
}
# (1 unchanged block hidden)
}
# (2 unchanged blocks hidden)
}
Plan: 0 to add, 10 to change, 0 to destroy.
Changes to Outputs:
~ service_account_keys_cleaner = {
~ service_account_keys_cleaner_cloud_run_service = {
id = "locations/europe-west4/namespaces/sap-kyma-prow/services/service-account-keys-cleaner"
name = "service-account-keys-cleaner"
~ template = [
~ {
~ spec = [
~ {
~ containers = [
~ {
~ image = "europe-docker.pkg.dev/kyma-project/prod/test-infra/service-account-keys-cleaner:v20250131-885542fa" -> "europe-docker.pkg.dev/kyma-project/prod/test-infra/service-account-keys-cleaner:v20250131-871459a2"
name = ""
# (10 unchanged attributes hidden)
},
]
# (5 unchanged attributes hidden)
},
]
# (1 unchanged attribute hidden)
},
]
# (7 unchanged attributes hidden)
}
# (2 unchanged attributes hidden)
}
~ service_account_keys_rotator = {
~ service_account_keys_rotator_cloud_run_service = {
id = "locations/europe-west4/namespaces/sap-kyma-prow/services/service-account-keys-rotator"
name = "service-account-keys-rotator"
~ template = [
~ {
~ spec = [
~ {
~ containers = [
~ {
~ image = "europe-docker.pkg.dev/kyma-project/prod/test-infra/rotate-service-account:v20250131-885542fa" -> "europe-docker.pkg.dev/kyma-project/prod/test-infra/rotate-service-account:v20250131-871459a2"
name = ""
# (10 unchanged attributes hidden)
},
]
# (5 unchanged attributes hidden)
},
]
# (1 unchanged attribute hidden)
},
]
# (7 unchanged attributes hidden)
}
# (3 unchanged attributes hidden)
} |
Sawthis
approved these changes
Jan 31, 2025
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add-or-update
cla: yes
Indicates the PR's author has signed the CLA.
lgtm
Looks good to me!
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image builder fails on retrieveing build report due to some weird things
Reverts #12620