stop traversing

kyoh86 · Dec 9, 2019 · 5380967 · 5380967
1 parent 2d466e6
commit 5380967
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 21 deletions.
diff --git a/internal/manager.go b/internal/manager.go
@@ -8,29 +8,31 @@ func (m *Manager) DeleteVer(v Semver) error {
 	if err := m.Tagger.DeleteTag(v.String()); err != nil {
 		return err
 	}
-	if v.Level() == LevelPatch {
-		_ = m.Tagger.DeleteTag(v.MinorString())
-	}
-	if v.Level() != LevelMajor {
-		_ = m.Tagger.DeleteTag(v.MajorString())
-	}
+	// TODO: traverse update versions with an option
+	// if v.Level() == LevelPatch {
+	// 	_ = m.Tagger.DeleteTag(v.MinorString())
+	// }
+	// if v.Level() != LevelMajor {
+	// 	_ = m.Tagger.DeleteTag(v.MajorString())
+	// }
 	return nil
 }
 
 func (m *Manager) CreateVer(v Semver, message []string, file string) error {
 	if err := m.Tagger.CreateTag(v.String(), message, file); err != nil {
 		return err
 	}
-	if v.Level() == LevelPatch {
-		if err := m.Tagger.CreateTag(v.MinorString(), message, file); err != nil {
-			return err
-		}
-	}
-	if v.Level() != LevelMajor {
-		if err := m.Tagger.CreateTag(v.MajorString(), message, file); err != nil {
-			return err
-		}
-	}
+	// TODO: traverse update versions with an option
+	// if v.Level() == LevelPatch {
+	// 	if err := m.Tagger.CreateTag(v.MinorString(), message, file); err != nil {
+	// 		return err
+	// 	}
+	// }
+	// if v.Level() != LevelMajor {
+	// 	if err := m.Tagger.CreateTag(v.MajorString(), message, file); err != nil {
+	// 		return err
+	// 	}
+	// }
 	return nil
 }
 

diff --git a/internal/manager_test.go b/internal/manager_test.go
@@ -21,18 +21,14 @@ func TestManager(t *testing.T) {
 	t.Run("create ver", func(t *testing.T) {
 		buf, _, man := tset()
 		assert.NoError(t, man.CreateVer(NewSemver("", 1, 2, 3), nil, ""))
-		assert.Equal(t, "git tag v1.2.3\ngit tag v1.2\ngit tag v1\n", buf.String())
+		assert.Equal(t, "git tag v1.2.3\n", buf.String())
 	})
 
 	t.Run("replace ver", func(t *testing.T) {
 		buf, _, man := tset()
 		assert.NoError(t, man.ReplaceVer(NewSemver("", 1, 2, 3), nil, ""))
 		assert.Equal(t, `git tag -d v1.2.3
-git tag -d v1.2
-git tag -d v1
 git tag v1.2.3
-git tag v1.2
-git tag v1
 `, buf.String())
 	})