Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow read-only transactions in Postgres and MySQL #1342

Merged
merged 6 commits into from
Feb 9, 2025
Merged

feat: Allow read-only transactions in Postgres and MySQL #1342

merged 6 commits into from
Feb 9, 2025

Conversation

B4nan
Copy link

@B4nan B4nan commented Feb 6, 2025

Closes #1341

@vercel Vercel
Copy link

vercel bot commented Feb 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 11:43am

@B4nan B4nan changed the base branch from master to v0.28 February 6, 2025 17:11
@B4nan B4nan mentioned this pull request Feb 6, 2025
Closed
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 8, 2025 •
edited
Loading

Open in Stackblitz • kysely_koa_example

npm i https://pkg.pr.new/kysely-org/kysely@1342

commit: 6fc9f29

@B4nan B4nan marked this pull request as ready for review February 9, 2025 10:06
@B4nan
Copy link
Author

B4nan commented Feb 9, 2025

@igalklebanov should be ready for review now

@igalklebanov igalklebanov added enhancement New feature or request custom dialect Related to a custom dialect mysql Related to MySQL postgres Related to PostgreSQL built-in dialect Related to a built-in dialect api Related to library's API labels Feb 9, 2025
@igalklebanov igalklebanov added the oracle Related to Oracle label Feb 9, 2025
igalklebanov
igalklebanov approved these changes Feb 9, 2025
View reviewed changes
Copy link
Member

@igalklebanov igalklebanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Thanks! 🙏

Added an AccessMode type and validation, extracted validation elsewhere. Rearranged/simplified/aligned transaction characteristics test cases between classic and controlled transaction suites.

@igalklebanov igalklebanov merged commit 7694816 into kysely-org:v0.28 Feb 9, 2025
27 checks passed
@igalklebanov igalklebanov mentioned this pull request Feb 9, 2025
Draft
igalklebanov added a commit that referenced this pull request Feb 9, 2025
@B4nan @igalklebanov
feat: Allow read-only transactions in Postgres and MySQL (#1342)
f7b3d90 
* feat: Allow read-only transactions in Postgres and MySQL

Closes #1341

* use `accessMode` instead

* add tests

* access mode type and validation, rearranging stuff a bit.

Co-authored-by: Martin Adámek <[email protected]>

* rearranging stuff a bit.

Co-authored-by: Martin Adámek <[email protected]>

* align/simplify tests a bit

Co-authored-by: Martin Adámek <[email protected]>

---------

Co-authored-by: igalklebanov <[email protected]>
Co-authored-by: Martin Adámek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalklebanov igalklebanov igalklebanov approved these changes

Assignees
No one assigned
Labels
api Related to library's API built-in dialect Related to a built-in dialect custom dialect Related to a custom dialect enhancement New feature or request mysql Related to MySQL oracle Related to Oracle postgres Related to PostgreSQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support read only transactions
2 participants
@B4nan @igalklebanov