Fix symbol and map glitches #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Luthaf
reviewed
Oct 18, 2024
|
|
||
| // in 3D mode, only strings are supported for 'marker.symbol'. | ||
| /* eslint-disable */ | ||
| const markers3d = require('./plotly/markers3d'); |
There was a problem hiding this comment.
can't get it to work as an import from both javascript and typescript in any other way. if you know how to do it, change it, I couldn't figure anything else that worked
Luthaf
approved these changes
Oct 21, 2024
|
Sorry I didn't get a chance to check this before you merged, but so far it looks like it fixes the problem for me as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #380 - or at least, patches up the most glaring problem and adds a bunch of symbols by monkey-patching plotly. The symbols are glyphs from fonts, so size depends on which font is picked that seems to be browser dependent. Also tackles a couple of small glitches when switching back and forth from 3D/2D