Revamped chemiscope icon #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luthaf
reviewed
Oct 29, 2024
There was a problem hiding this comment.
I like the change overall, here are a couple of suggestions:
- I find the telescope a bit too big IMO, meaning it is pushing points in the axes, making the 32px version a bit noisy and not well defined
- Should we have a version with the project name inside as well? We are currently using one in https://docs.metatensor.org/latest/atomistic/engines/index.html
Luthaf
reviewed
Oct 29, 2024
Luthaf
approved these changes
Oct 30, 2024
I'd say that's for another PR working on restyling the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VERY important PR of course. A "nicer" icon for chemiscope so we can also make stickers ^^
Old:
New:
