Removing internal neighbor calculations #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PicoCentauri
force-pushed
the
require-neighborlist
branch
5 times, most recently
from
38e3266 to
5fbce94
Compare
PicoCentauri
changed the title
PicoCentauri
force-pushed
the
require-neighborlist
branch
from
5fbce94 to
9aa0b42
Compare
PicoCentauri
force-pushed
the
require-neighborlist
branch
from
9aa0b42 to
3f6b2c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is first step towards making the torchscript again.
I also removed the
sr_cutoffparameter which becomes useless if there are no neighbor calculations anymore.My idea is to use the vesin project for computing the neighbors in the tests and examples
TODO
📚 Documentation preview 📚: https://meshlode--18.org.readthedocs.build/en/18/