fix: custom fields cache concurrent writes

.changes/unreleased/Fixed-20250206-113217.yaml

@@ -0,0 +1,3 @@
+kind: Fixed
+body: Custom fields cache concurrent writes
+time: 2025-02-06T11:32:17.345811+01:00

commercetools/custom_fields.go

@@ -6,13 +6,15 @@ import (
 	"fmt"
 	"strconv"
 	"strings"
+	"sync"
 	"time"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 	"github.com/labd/commercetools-go-sdk/platform"
 )
 
 var cacheTypes map[string]*platform.Type
+var cacheTypesLock sync.Mutex
 
 func CustomFieldSchema() *schema.Schema {
 	return &schema.Schema{
@@ -257,6 +259,7 @@ func getTypeResourceFromResourceData(ctx context.Context, client *platform.ByPro
 // field. The type_id is cached to minimize API calls when multiple resource
 // use the same type
 func GetTypeResource(ctx context.Context, client *platform.ByProjectKeyRequestBuilder, typeId string) (*platform.Type, error) {
+	cacheTypesLock.Lock()
 	if cacheTypes == nil {
 		cacheTypes = make(map[string]*platform.Type)
 	}
@@ -266,9 +269,14 @@ func GetTypeResource(ctx context.Context, client *platform.ByProjectKeyRequestBu
 		}
 		return t, nil
 	}
+	cacheTypesLock.Unlock()
 
 	t, err := client.Types().WithId(typeId).Get().Execute(ctx)
+
+	cacheTypesLock.Lock()
 	cacheTypes[typeId] = t
+	cacheTypesLock.Unlock()
+
 	return t, err
 }