Change how method get_genes handle end position #212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
get_genes
handled the last position to agree with Python list slicing syntax, i.e., if the begin was 0 and the end was 5,get_genes
returned genes at positions 0, 1, 2, 3, and 4. In the PPanGGOLiN algorithms, the syntax was known, and the results were what was expected.However, we judged that was not the intended behavior of the method. So now,
get_genes
includes the gene in the position end. Also, an argumentoutrange_ok
(boolean = False by default) was added to prevent some out-of-range index errors.