Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata from annotation files #227

Merged
merged 25 commits into from
Jun 3, 2024
Merged

Add metadata from annotation files #227

merged 25 commits into from
Jun 3, 2024

Conversation

JeanMainguy
Copy link
Member

@JeanMainguy JeanMainguy commented May 21, 2024

This PR extracts information from annotation files (GBFF and GFF) and adds them as metadata to genomes and contigs in the pangenome file.

Tasks to complete:

  • Extract and add metadata from GBFF files
  • Extract and add metadata from GFF files
  • Display metadata by default in output files
  • Give the possibility to output metadata in TSV format from the pangenome file
  • Update metadata documentation

I have completely redesigned the read_org_gbff function to simplify metadata extraction from GBFF files.

Metadata will still no be displayed in output files by default as this behavior may lead to some error regarding the metadata separator. If the user want to display metadata in the output files, it needs to add the --add_metadata flag as before.

Note: This PR builds on the AnnotJoin branch, which has introduced several changes to annotation file parsing. Therefore, it is dependent on PR #206 and should be merged afterward.

@JeanMainguy JeanMainguy marked this pull request as ready for review May 27, 2024 09:02
@jpjarnoux jpjarnoux self-requested a review May 27, 2024 09:24
@jpjarnoux jpjarnoux closed this Jun 3, 2024
@jpjarnoux jpjarnoux reopened this Jun 3, 2024
@jpjarnoux jpjarnoux changed the base branch from dev to devForPanorama June 3, 2024 13:14
@jpjarnoux jpjarnoux changed the base branch from devForPanorama to dev June 3, 2024 13:14
Copy link
Member

@jpjarnoux jpjarnoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge after correction on comments

ppanggolin/geneFamily.py Show resolved Hide resolved
ppanggolin/metadata.py Outdated Show resolved Hide resolved
ppanggolin/metadata.py Outdated Show resolved Hide resolved
ppanggolin/pangenome.py Outdated Show resolved Hide resolved
ppanggolin/formats/writeFlatMetadata.py Show resolved Hide resolved
@jpjarnoux jpjarnoux merged commit 98a73f3 into dev Jun 3, 2024
4 checks passed
@jpjarnoux jpjarnoux deleted the improve_metadata branch June 3, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants