Fix config outputs in workflow commands when set in config file #261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses an issue with the default behavior of flat output file generation in workflow commands when specified through the configuration file.
Background
In the commands
write_pangenome
,write_genome
, anddraw
, the default setting for output files isfalse
, requiring users to explicitly specify the desired files via the command line. However, within workflow commands, these outputs are generated by default unless the--no_flat_files
parameter is used. The intended behavior was to force output files to be generated by default unless overridden by the configuration file or CLI arguments.Issue
The previous implementation incorrectly forced output file generation even when the configuration file specified
false
for certain outputs. This made it impossible to selectively generate some outputs while omitting others.Fix
This PR corrects the handling of configuration and CLI arguments, ensuring that the specified settings in the configuration file are respected. Now, the correct outputs will be generated based on user specifications, allowing for more granular control over the output files.
Additional Fix
The
compress
flag, intended to compress output files, was previously not applied to thegenomes_statistics.tsv
file. This PR ensures that the file can now be generated in a compressed format if thecompress
flag is set.