Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config outputs in workflow commands when set in config file #261

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

JeanMainguy
Copy link
Member

Summary

This PR addresses an issue with the default behavior of flat output file generation in workflow commands when specified through the configuration file.

Background

In the commands write_pangenome, write_genome, and draw, the default setting for output files is false, requiring users to explicitly specify the desired files via the command line. However, within workflow commands, these outputs are generated by default unless the --no_flat_files parameter is used. The intended behavior was to force output files to be generated by default unless overridden by the configuration file or CLI arguments.

Issue

The previous implementation incorrectly forced output file generation even when the configuration file specified false for certain outputs. This made it impossible to selectively generate some outputs while omitting others.

Fix

This PR corrects the handling of configuration and CLI arguments, ensuring that the specified settings in the configuration file are respected. Now, the correct outputs will be generated based on user specifications, allowing for more granular control over the output files.

Additional Fix

The compress flag, intended to compress output files, was previously not applied to the genomes_statistics.tsv file. This PR ensures that the file can now be generated in a compressed format if the compress flag is set.

@JeanMainguy JeanMainguy changed the title Fix config outputs in wf Fix config outputs in workflow commands when set in config file Aug 2, 2024
@axbazin axbazin assigned axbazin and unassigned axbazin Aug 5, 2024
@axbazin axbazin self-requested a review August 5, 2024 11:51
@axbazin axbazin merged commit 1a6a5c4 into dev Aug 5, 2024
4 checks passed
@axbazin axbazin deleted the fix_config_outputs_in_wf branch August 5, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants