Write the gene families by ordering the cluster based on their size. #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpjarnoux
force-pushed
the
deterCluster
branch
from
e43de5b to
3c2f9c8
Compare
JeanMainguy
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is linked to the issue #263.
When the genes of gene families were written to the tsv, genes were randomly sorted. As reported in issue #263, clustering appeared non-deterministic, even though the number of clusters was the same. By ordering the clusters by size and the genes alphabetically, the
gene_families.tsvfile is the same between severalppanggolin clusterexecutions.This change makes it possible to test whether there is a difference between the expected and the computed clustering in the GitHub action. We added a checksum file containing sha256sum for each
gene_families.tsv, and when the file is written in action, the sha256sum is tested.Also, as mentioned in the issue, the
result2repseqmmseqs2 command was missing the--threadoption. This has been fixed.N.B., it could be a good thing to add more sha256sum check for output file.