Handle case where a spotless pangenome is used in projection #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An edge case have been identified in issue #264 where a pangenome without any existing spots is used in a projection. In this case, the projection process, which predicts spots in the input genome, attempts to retrieve the highest spot ID to determine the appropriate ID for any new spots detected. This leads to an error when no spot IDs are available.
To resolve this, I’ve implemented a check to see if the pangenome contains any spots. If no spots are found, the process will now default to using an ID of 1 for new spots.