Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dev branch into master to release version 2.2.0 #298

Merged
merged 61 commits into from
Oct 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
96ec865
write fasta by reading directly from the pangenome file
JeanMainguy Sep 16, 2024
1b3b35f
add module filter in gene_families writing
JeanMainguy Sep 17, 2024
c14eac4
fix none manageemnt
JeanMainguy Sep 17, 2024
1ac566c
write module and rgp family genes
JeanMainguy Sep 18, 2024
7b8c6c2
fix an error in the formula to calculate chao displayed on the ucurve…
ggautreau Sep 18, 2024
2518942
add possibility to write module and rgp in prot fasta
JeanMainguy Sep 18, 2024
1157761
Add possibility to write genes by reading pangenome file directly
JeanMainguy Sep 18, 2024
3a6840c
reset genes var if it has been handle by writting fct
JeanMainguy Sep 18, 2024
cae0c4a
remove trailing whitespaces
fchapoton Sep 19, 2024
b0d5d19
a few more fixes by hand
fchapoton Sep 19, 2024
6bae993
Merge pull request #284 from labgem/fix_ucurve_chao
axbazin Sep 19, 2024
825e1e7
add softcore and core filter in gene_families output
JeanMainguy Sep 19, 2024
25c61bc
add softcore and core filter in prot_families output
JeanMainguy Sep 19, 2024
baa9a0f
handle proteins in faster way
JeanMainguy Sep 19, 2024
cfc9073
clean region seq writting
JeanMainguy Sep 19, 2024
bd592d0
add docstring and clean fct not used
JeanMainguy Sep 19, 2024
cd30d15
clean import
JeanMainguy Sep 20, 2024
bc18e15
use set instead of list to speed gene selection
JeanMainguy Sep 20, 2024
06e47df
improve error management and refactor code for more clarity
JeanMainguy Sep 25, 2024
dd84093
ignore empty metadata tag in annotation file
JeanMainguy Sep 25, 2024
4706587
Merge pull request #287 from labgem/fix_genome_metadata_handeling
axbazin Sep 25, 2024
2923c56
Merge pull request #283 from labgem/improve_fasta_cmd
axbazin Sep 27, 2024
0c1b85e
Merge pull request #286 from fchapoton/trailing_spaces
JeanMainguy Oct 9, 2024
7bb83ce
identify starting and ending partiality of gene
JeanMainguy Oct 9, 2024
ad44264
fix coordinates for partial genes
JeanMainguy Oct 10, 2024
b8b1f42
add pytest for fixing coordinates fct
JeanMainguy Oct 10, 2024
2a62ee8
refactor shifting function to handle tricky coordinates and reuse code
JeanMainguy Oct 10, 2024
aa4e988
update tests to match refactoring and tricky cases
JeanMainguy Oct 10, 2024
0507a4b
do not ignore CDS with trans_except instead give a warning
JeanMainguy Oct 14, 2024
1e99584
simplify fct fix_partial_gene_coordinates
JeanMainguy Oct 14, 2024
9816e93
rm old args from fct
JeanMainguy Oct 14, 2024
01c5cfe
ignore NaturalNameWarning from tables as it is not really necessary
JeanMainguy Oct 14, 2024
520a84a
handle partial genes from GFF files
JeanMainguy Oct 14, 2024
a79076b
rm debug log
JeanMainguy Oct 15, 2024
d99404c
rm debug
JeanMainguy Oct 15, 2024
e802d5e
use locus_tag in GFF parsing
JeanMainguy Oct 15, 2024
7cb227c
update CI
JeanMainguy Oct 15, 2024
6507c57
update expected files with new genes and cluster
JeanMainguy Oct 15, 2024
498b033
Revert "update CI"
JeanMainguy Oct 15, 2024
0ed382a
update CI
JeanMainguy Oct 15, 2024
760b0f0
rm cluster file not used in CI anymore
JeanMainguy Oct 15, 2024
a9a251f
Fix how frame getter/setter attribute is handled
jpjarnoux Oct 18, 2024
6940253
Update docstring and typing
jpjarnoux Oct 18, 2024
561d81b
Merge pull request #290 from labgem/handle_partial_genes
jpjarnoux Oct 18, 2024
0b6d1df
filter out non ascii character when found in product
JeanMainguy Oct 16, 2024
fbe6132
add some pytest to test ascii filtering fct
JeanMainguy Oct 16, 2024
1fd1092
Merge pull request #291 from labgem/filter_non_ascii_char
jpjarnoux Oct 21, 2024
70155bd
apply black to ppanggolin python code
JeanMainguy Oct 29, 2024
73dd3df
add black to test deps in toml
JeanMainguy Oct 29, 2024
5d8305a
add CI lint
JeanMainguy Oct 29, 2024
348a7af
fix synthax error in toml
JeanMainguy Oct 29, 2024
de47131
test black
JeanMainguy Oct 29, 2024
99249ed
test black revert
JeanMainguy Oct 29, 2024
798f850
update doc with black
JeanMainguy Oct 29, 2024
4e2b9df
add black github link in doc
JeanMainguy Oct 29, 2024
ac13ec7
add missing disable bar flag in fast projection
JeanMainguy Oct 29, 2024
af0c675
use debug to inform on missing translation table in input files
JeanMainguy Oct 29, 2024
9526e46
Merge pull request #295 from labgem/add_linter
JeanMainguy Oct 29, 2024
e3713ca
Bump to version 2.2.0
JeanMainguy Oct 29, 2024
92263af
Merge pull request #296 from labgem/adjust_log_and_bar
axbazin Oct 29, 2024
23c4fd7
Merge pull request #297 from labgem/update_version
axbazin Oct 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/black_lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
name: Lint

on: [push, pull_request]

jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: psf/black@stable
1 change: 1 addition & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ jobs:
shell: bash -l {0}
run: |
cd testingDataset
cat myannopang/gene_families.tsv | cut -f1,2,4 > clusters.tsv
ppanggolin panrgp --anno genomes.gbff.list --cluster clusters.tsv --output readclusterpang --cpu $NUM_CPUS
ppanggolin annotate --anno genomes.gbff.list --output readclusters --cpu $NUM_CPUS
awk 'BEGIN{FS=OFS="\t"} {$1 = $1 OFS $1} 1' clusters.tsv > clusters_with_reprez.tsv;
Expand Down
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2.1.2
2.2.0
24 changes: 12 additions & 12 deletions docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,14 @@

# -- Project information -----------------------------------------------------

project = 'PPanGGOLiN'
copyright = '2023, LABGeM'
author = 'Jérôme Arnoux'
project = "PPanGGOLiN"
copyright = "2023, LABGeM"
author = "Jérôme Arnoux"

# The full version, including alpha/beta/rc tags
release = open(Path(__file__).resolve().parents[1]/"VERSION").read().rstrip() # Get release number in the VERSION file
release = (
open(Path(__file__).resolve().parents[1] / "VERSION").read().rstrip()
) # Get release number in the VERSION file


# -- General configuration ---------------------------------------------------
Expand All @@ -33,21 +35,19 @@
"sphinx.ext.duration",
"sphinx.ext.autosectionlabel",
"sphinx.ext.autodoc",
'sphinx_search.extension',
'sphinxcontrib.mermaid'
"sphinx_search.extension",
"sphinxcontrib.mermaid",
]


source_suffix = {
'.md': 'markdown'
}
source_suffix = {".md": "markdown"}

# Prefix document path to section labels, to use:
# `path/to/file:heading` instead of just `heading`
autosectionlabel_prefix_document = True

# Add any paths that contain templates here, relative to this directory.
templates_path = ['_templates']
templates_path = ["_templates"]

# List of patterns, relative to source directory, that match files and
# directories to ignore when looking for source files.
Expand All @@ -60,9 +60,9 @@
# The theme to use for HTML and HTML Help pages. See the documentation for
# a list of builtin themes.
#
html_theme = 'sphinx_rtd_theme'
html_theme = "sphinx_rtd_theme"

# Add any paths that contain custom static files (such as style sheets) here,
# relative to this directory. They are copied after the builtin static files,
# so a file named "default.css" will overwrite the builtin "default.css".
html_static_path = ['_static']
html_static_path = ["_static"]
28 changes: 20 additions & 8 deletions docs/dev/contribute.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,35 +8,47 @@ If you have ideas for new features or improvements, initiating a discussion in a

For minor changes like fixing typos or making small edits, feel free to create a new Pull Request (PR) directly with your proposed changes.


## Setting Up the Development Environment

1. **Fork the Repository:** Start by forking the repository to your GitHub account. 🍴
1. **Fork the Repository:**
Start by forking the repository to your GitHub account. 🍴

2. **Clone the Forked Repository:** Clone your forked repository to your local machine.
2. **Clone the Forked Repository:**
Clone your forked repository to your local machine.

3. **Get an Environment:** Create an environment with all PPanGGOLiN prerequisites installed. For that, you can follow installation instructions [here](../user/install.md#installing-from-source-code-github).

4. **Branch from 'dev':** Begin your changes from the 'dev' branch, where we incorporate changes for the upcoming release.
4. **Branch from 'dev':**
Begin your changes from the 'dev' branch, where we incorporate changes for the upcoming release.


5. **Install in Editable Mode:**

5. **Install in Editable Mode:** To enable seamless code editing and testing of new functionality, install PPanGGOLiN in editable mode using the following command:
To enable code editing and testing of new functionality, you can install PPanGGOLiN in editable mode using the following command:

```bash
pip install -e .
```

This allows you to modify the code and experiment with new features directly.

```{note}
Note: Currently, we are not utilizing any auto formatters (like autopep8 or black). Kindly refrain from using them, as it could introduce extensive changes across the project, making code review challenging for us.
6. **Apply Code Formatting with Black:**
We have integrated [Black](https://github.com/psf/black) as our code formatter to maintain consistent styling. Code changes are automatically checked via a GitHub Action in our CI, so **ensure your code is formatted with Black before committing**.


```{tip}
Integrate Black with your IDE to automatically format your changes and avoid formatting-related CI failures.
```


## Making Your Changes

We encourage consistency in code formatting; when adding new code, try to follow the existing code structure as closely as possible. Functions should include descriptive docstrings explaining their purpose and detailing the parameters. Ensure that argument types are specified in the function definitions.
Keep it consistent! Match the existing code style, add docstrings to describe functions, and specify argument types.

## Update Documentation

It's essential to update the documentation to reflect your changes. Provide clear descriptions and, if necessary, examples of commands and their respective outputs.
Update docs to reflect changesclear descriptions and examples are always helpful!

## Tests

Expand Down
2 changes: 1 addition & 1 deletion ppanggolin/RGP/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
from .genomicIsland import subparser, launch
from .spot import *
from . import rgp_cluster
from . import rgp_cluster
Loading
Loading