USBStorageDriver cleanup remote resource #1588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using ManagedFile with remote resources without NFS, files copied to the remote by sync_to_resource() method will not be deleted automatically. While it is of-course possible to use something like systemd-tmpfiles to cleanup after a while, files might pile up and cause out of diskspace situations before systemd-tmpfiles gets to it. This method can be used by users of ManagedFile objects to cleanup the remote copy of the file when it is no longer needed. Signed-off-by: Esben Haabendal <[email protected]>
Delete the remote resource copy of the files being written to USB storage when done, avoiding filling up /var/cache/labgrid over time. Keep in mind, that this this can be used for writing quite large files, so can fill up storage on an exporter quite fast. Signed-off-by: Esben Haabendal <[email protected]>
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #1588 +/- ##
========================================
- Coverage 56.0% 55.9% -0.1%
========================================
Files 170 170
Lines 13307 13322 +15
========================================
+ Hits 7458 7459 +1
- Misses 5849 5863 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Please see the "Attention" box in the Exporter documentation. This PR disables the caching completely, you should be able to configure the cleanup interval for your infrastructure to shorter intervals if storage is tight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the USBStorageDriver class to cleanup remote files (ManagedFile) when the remote copy of the files have been used.
This helps avoid running out of disk space on the remote resource, especially if using USBStorageDriver with large image files.
Checklist