Feat/init repo #1
Conversation
| @@ -0,0 +1,50 @@ | |||
| name: Build and publish Docker images | |||
There was a problem hiding this comment.
I think this could be merged with the latest workflow by using some conditionals https://docs.github.com/en/actions/using-jobs/using-conditions-to-control-job-execution, https://stackoverflow.com/questions/66458906/how-to-conditionally-run-github-workflow-action-only-for-tags-made-on-specific-b?
.github/workflows/helm-lint-test.yml
Outdated
There was a problem hiding this comment.
I would like to have a chat about this workflow, what we want to achieve here etc.
There was a problem hiding this comment.
I will remove this action and helm release will be part of next PR
charts/aws-service-quotas-exporter/ci/aws-service-quotas-exporter-values.yaml
Show resolved
Hide resolved
test/configs/eip.yaml
Outdated
| metrics: | ||
| - name: "route53_hosted_zone_records" | ||
| help: "Number of resource sets in hosted zone" | ||
| script: "aws route53 list-hosted-zones | jq -r '.HostedZones[] | \"id=\(.Id),name=\(.Name),\(.ResourceRecordSetCount)\"'" |
There was a problem hiding this comment.
Add to the example label with a value if the zone is private, ie. private=(.Config.PrivateZone)
| runAsNonRoot: true | ||
| runAsUser: 1000 | ||
| capabilities: | ||
| add: ["NET_ADMIN", "NET_RAW"] |
There was a problem hiding this comment.
Why are these needed? We should force uses to use non-protected ports when running the Pod
No description provided.