feat(FR-17): update desired_session_count field name to replicas
#2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.95% (-0% 🔻) |
398/8033 |
| 🔴 | Branches | 4.26% (-0.02% 🔻) |
237/5558 |
| 🔴 | Functions | 2.97% (-0% 🔻) |
78/2627 |
| 🔴 | Lines | 4.87% (-0% 🔻) |
383/7860 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from a84073a
ironAiken2
changed the title
desired_session_count field name to replicasdesired_session_count field name to replicas
ironAiken2
force-pushed
the
feat/deprecated-session-routing-count
branch
from
ea9696c to
cc9297b
Compare
ironAiken2
force-pushed
the
feat/deprecated-session-routing-count
branch
3 times, most recently
from
70d4813 to
662efcf
Compare
ironAiken2
force-pushed
the
feat/deprecated-session-routing-count
branch
from
662efcf to
a8eabef
Compare
ironAiken2
force-pushed
the
feat/deprecated-session-routing-count
branch
2 times, most recently
from
6451393 to
d30759e
Compare
ironAiken2
force-pushed
the
feat/deprecated-session-routing-count
branch
from
d30759e to
8883415
Compare
agatha197
requested changes
Jan 8, 2025
ironAiken2
force-pushed
the
feat/deprecated-session-routing-count
branch
from
8883415 to
15159d9
Compare
agatha197
requested changes
Jan 9, 2025
ironAiken2
force-pushed
the
feat/deprecated-session-routing-count
branch
from
15159d9 to
9e5eeb9
Compare
yomybaby
requested changes
Jan 10, 2025
ironAiken2
force-pushed
the
feat/deprecated-session-routing-count
branch
3 times, most recently
from
f49d41a to
e150168
Compare
agatha197
requested changes
Jan 14, 2025
ironAiken2
force-pushed
the
feat/deprecated-session-routing-count
branch
from
e150168 to
9238ad9
Compare
agatha197
requested changes
Jan 14, 2025
ironAiken2
force-pushed
the
feat/deprecated-session-routing-count
branch
from
9238ad9 to
8221836
Compare
agatha197
requested changes
Jan 14, 2025
ironAiken2
changed the title
desired_session_count field name to replicasdesired_session_count field name to replicas
agatha197
approved these changes
Jan 14, 2025
ironAiken2
force-pushed
the
feat/deprecated-session-routing-count
branch
from
8221836 to
f8b4738
Compare
Merge activity
|
…2963) ### This PR resolves [#2957](#2957) issue Since Backend.AI Core version 24.12.0, the desired_session_count field has been replaced with `replicas`. **Changes:** - Added `replicas` field to service creation and update interfaces - Deprecated `desired_session_count` field for manager version >= 24.12.0 - Updated GraphQL queries to handle both `desired_session_count` and `replicas` fields - Added version-based field selection using `@deprecatedSince` and `@since` directives - Added `replicas` feature flag check in client capabilities **How to test:** - Check whether `desired_session_count` or `replicas` is used when creating or modifying a service, depending on the manager version. (From 24.12.0 onwards, replicas is used.) - Check whether desired_session_count is displayed correctly on the Service page and Detail page.
agatha197
force-pushed
the
feat/deprecated-session-routing-count
branch
from
f8b4738 to
a84073a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2957 issue
Since Backend.AI Core version 24.12.0, the desired_session_count field has been replaced with
replicas.Changes:
replicasfield to service creation and update interfacesdesired_session_countfield for manager version >= 24.12.0desired_session_countandreplicasfields@deprecatedSinceand@sincedirectivesreplicasfeature flag check in client capabilitiesHow to test:
desired_session_countorreplicasis used when creating or modifying a service, depending on the manager version. (From 24.12.0 onwards, replicas is used.)