Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FR-84): add multiple file download support in folder explorer #3005

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nowgnuesLee
Copy link
Contributor

@nowgnuesLee nowgnuesLee commented Jan 8, 2025

This PR resolves #2100

changes

  • Add a download button between delete and create
  • Add _downloadMultipleFiles function on backend-ai-folder-explorer.ts. This function asynchronously requests download link for files to server, with a download interval of 500ms between each files. (If it's too much, it should be taken into consideration.)

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

* add _downloadMultipleFiles function on backend-ai-folder-explorer.ts
@github-actions github-actions bot added the size:M 30~100 LoC label Jan 8, 2025
Copy link

cla-assistant bot commented Jan 8, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

graphite-app bot commented Jan 8, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

cla-assistant bot commented Jan 8, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

github-actions bot commented Jan 8, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
4.98% (-0% 🔻)
398/7994
🔴 Branches
4.3% (-0% 🔻)
237/5506
🔴 Functions
2.98% (-0% 🔻)
78/2615
🔴 Lines
4.9% (-0% 🔻)
383/7821

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from fd4012e

@nowgnuesLee nowgnuesLee marked this pull request as ready for review January 8, 2025 07:19
@nowgnuesLee nowgnuesLee requested a review from agatha197 January 8, 2025 08:09
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's consider implementing an API for downloading multiple files, including folders.

@yomybaby yomybaby changed the title feat: add a button to download multiple files [FR-84] feat: add multiple file download support in folder explorer Jan 10, 2025
@nowgnuesLee nowgnuesLee marked this pull request as draft January 14, 2025 07:06
@nowgnuesLee nowgnuesLee changed the title [FR-84] feat: add multiple file download support in folder explorer feat(FR-84): add multiple file download support in folder explorer Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let's add feature of downloading all of files at once and relocate controls button in vfolder explorer
2 participants