Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FR-434): support math in model card. #3067

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Jan 23, 2025

resolves #3066 (FR-434 / parent: FR-432)

Added support for LaTeX math expressions and GitHub Flavored Markdown (GFM) in chat messages by integrating KaTeX, remark-gfm, and remark-math plugins into the markdown renderer.

How to test:
Use deepseek model in dogbowl and verify:

  1. LaTeX math expressions render correctly (both inline and block)
  2. GFM features work (tables, strikethrough, task lists, etc.)

Screenshots:
Result of

$$Euler’s identity $e^{i\pi}+1=0$ is a beautiful formula in $\mathbb{R}^2$. $$ \frac {\partial^r} {\partial \omega^r} \left(\frac {y^{\omega}} {\omega}\right) = \left(\frac {y^{\omega}} {\omega}\right) \left\{(\log y)^r + \sum_{i=1}^r \frac {(-1)^ Ir \cdots (r-i+1) (\log y)^{ri}} {\omega^i} \right\} $$$$

image.png

Checklist:

  • Documentation
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions bot added the size:L 100~500 LoC label Jan 23, 2025
Copy link
Contributor Author

agatha197 commented Jan 23, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Jan 23, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 4.9% 398/8116
🔴 Branches 4.24% 239/5635
🔴 Functions 2.95% 78/2643
🔴 Lines 4.82% 383/7941

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 445dd03

@agatha197 agatha197 force-pushed the feature/support-latex branch 2 times, most recently from e29d712 to 78f8376 Compare January 31, 2025 07:18
@agatha197 agatha197 marked this pull request as draft January 31, 2025 07:18
@agatha197 agatha197 force-pushed the feature/support-latex branch from 78f8376 to 3baabc2 Compare January 31, 2025 07:46
@agatha197 agatha197 force-pushed the feature/support-latex branch from 3baabc2 to 445dd03 Compare January 31, 2025 07:47
@agatha197 agatha197 marked this pull request as ready for review January 31, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve model card UI
1 participant