-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(FR-393): add e2e test for maintenance page #3074
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a commit to prevent unexpected notification closure., LGTM now.
Merge activity
|
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 4.69% | 400/8534 |
🔴 | Branches | 4.06% | 239/5886 |
🔴 | Functions | 2.84% | 78/2747 |
🔴 | Lines | 4.61% | 385/8351 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 19d5d79
resolves #3041, [(FR-393)](https://lablup.atlassian.net/browse/FR-393) **changes** * Added test cases for `Rescan Images` and `Recalculate Usage` on the `maintenance` page. * Added functions in `test-util-antd.ts` to retrieve notification text. * Added `1-minute` timeout to rescan image test (1min) **Checklist:** - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
24a6198
to
19d5d79
Compare
resolves #3041, (FR-393)
changes
Rescan Images
andRecalculate Usage
on themaintenance
page.test-util-antd.ts
to retrieve notification text.1-minute
timeout to rescan image test (1min)Checklist: