Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(FR-393): add e2e test for maintenance page #3074

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

nowgnuesLee
Copy link
Contributor

@nowgnuesLee nowgnuesLee commented Jan 23, 2025

resolves #3041, (FR-393)

changes

  • Added test cases for Rescan Images and Recalculate Usage on the maintenance page.
  • Added functions in test-util-antd.ts to retrieve notification text.
  • Added 1-minute timeout to rescan image test (1min)

Checklist:

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link

graphite-app bot commented Jan 23, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

e2e/maintenance.test.ts Show resolved Hide resolved
@nowgnuesLee nowgnuesLee requested a review from yomybaby February 5, 2025 06:52
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a commit to prevent unexpected notification closure., LGTM now.

Copy link

graphite-app bot commented Feb 7, 2025

Merge activity

Copy link

github-actions bot commented Feb 7, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 4.69% 400/8534
🔴 Branches 4.06% 239/5886
🔴 Functions 2.84% 78/2747
🔴 Lines 4.61% 385/8351

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 19d5d79

resolves #3041, [(FR-393)](https://lablup.atlassian.net/browse/FR-393)

**changes**
* Added test cases for `Rescan Images` and `Recalculate Usage` on the `maintenance` page.
* Added functions in `test-util-antd.ts` to retrieve notification text.
* Added `1-minute` timeout to rescan image test (1min)

**Checklist:**

- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@graphite-app graphite-app bot force-pushed the feature/test-maintenance branch from 24a6198 to 19d5d79 Compare February 7, 2025 11:17
@graphite-app graphite-app bot merged commit 19d5d79 into main Feb 7, 2025
6 checks passed
@graphite-app graphite-app bot deleted the feature/test-maintenance branch February 7, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E test for maintenance page
2 participants