refactor(FR-XXX): Restructure schema for theme.json
#3078
+68
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.9% | 398/8116 |
| 🔴 | Branches | 4.24% | 239/5635 |
| 🔴 | Functions | 2.95% | 78/2643 |
| 🔴 | Lines | 4.82% | 383/7941 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 2642e11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #NNN (FR-MMM)
This pull request includes significant changes to the logo configuration in the WebUI. The changes involve restructuring the logo properties to separate the collapsed logo configuration and updating the related files accordingly.
Key changes include:
Logo Configuration Updates:
react/src/components/MainLayout/WebUISider.tsx: Updated the logo properties to uselogoCollapsedfor the collapsed state, ensuring the correct logo is displayed based on the sider theme.react/src/helper/customThemeConfig.ts: Modified theLogoConfigtype to remove collapsed-specific properties and added a newlogoCollapsedproperty to the theme configuration. [1] [2] [3]resources/logo.schema.json: Added a new JSON schema file to define the structure of the logo configuration, including properties for the logo source, title, alt text, href, and size.resources/theme.json: Updated the theme configuration to separate the main logo and the collapsed logo configurations.resources/theme.schema.json: Updated the theme schema to reference the newlogo.schema.jsonfor both the main and collapsed logo configurations.These changes enhance the flexibility and clarity of the logo configuration in the WebUI, making it easier to manage and customize the appearance based on different states.
Checklist: (if applicable)