Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FR-472): empty resource preset in service launcher #3113

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Feb 7, 2025

resolves #3114 (FR-472)

Adds allocationPreset parameter with default value of 'auto-select' to the service launcher configuration, enabling automatic resource allocation for new service instances.

Copy link
Member Author

yomybaby commented Feb 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yomybaby yomybaby requested a review from ironAiken2 February 7, 2025 09:47
@yomybaby yomybaby marked this pull request as ready for review February 7, 2025 09:49
@ironAiken2 ironAiken2 force-pushed the fix/service-update-page branch from 2ea022d to dd7faf6 Compare February 7, 2025 09:51
@ironAiken2 ironAiken2 force-pushed the fix/empty-resource-preset-in-service-launcher branch from 507fab3 to 0961710 Compare February 7, 2025 09:53
@yomybaby yomybaby changed the base branch from fix/service-update-page to graphite-base/3113 February 7, 2025 09:55
Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

graphite-app bot commented Feb 7, 2025

Merge activity

@graphite-app graphite-app bot changed the base branch from graphite-base/3113 to main February 7, 2025 09:57
resolves #3114 (FR-472)

Adds `allocationPreset` parameter with default value of 'auto-select' to the service launcher configuration, enabling automatic resource allocation for new service instances.
@graphite-app graphite-app bot force-pushed the fix/empty-resource-preset-in-service-launcher branch from 0961710 to 59d4cf5 Compare February 7, 2025 09:59
Copy link

github-actions bot commented Feb 7, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 4.69% 400/8534
🔴 Branches 4.06% 239/5886
🔴 Functions 2.84% 78/2747
🔴 Lines 4.61% 385/8351

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 59d4cf5

@graphite-app graphite-app bot merged commit 59d4cf5 into main Feb 7, 2025
7 checks passed
@graphite-app graphite-app bot deleted the fix/empty-resource-preset-in-service-launcher branch February 7, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS ~10 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: empty resource preset initial value in Service launcher
2 participants