-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(BA-145): Implement CRUD API for managing Harbor per-project Quota #3090
Merged
HyeockJinKim
merged 75 commits into
main
from
topic/11-13-feat_implement_management_api_for_controlling_harbor_per-project_quota
Feb 13, 2025
Merged
Changes from all commits
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
7762a25
feat: Implement management API for controlling Harbor per-project Quota
jopemachine 49f60c9
chore: Add news fragment
jopemachine 683f927
fix: Disable user quota mutation
jopemachine b832cf9
fix: Rename variables
jopemachine 71d2aaa
feat: Add `registry_quota` to GroupNode
jopemachine 7231fc3
fix: Update `UpdateQuota` mutation
jopemachine 954306e
fix: Update `resolve_registry_quota`
jopemachine 9ac1222
fix: Update `resolve_registry_quota`
jopemachine eaf0949
fix: Only authorized groups view the quota
jopemachine b5d220b
feat: Add CreateQuota, DeleteQuota mutation
jopemachine 32eba43
chore: Rename function
jopemachine 89b79e2
fix: Add exception handling for each operation
jopemachine 5ae4e94
chore: Update schema
jopemachine 23aceb6
chore: Update error msg
jopemachine 321cf13
chore: Rename variable
jopemachine db23891
fix: Remove useless strenum
jopemachine 6edd921
refactor: `mutate_harbor_project_quota`
jopemachine b38a8a6
refactor: Add read operation handling for code reuse
jopemachine ff568ab
feat: Add SDK for registry quota mutations
jopemachine e465c3d
fix: Broken CI
jopemachine f022d4c
feat: Implement REST API
jopemachine 3c2ea70
fix: Wrong exception handling
jopemachine ee79ed4
chore: Update comment
jopemachine f3f7691
chore: Rename types
jopemachine 720075e
chore: update GraphQL schema dump
jopemachine 370a11e
chore: Rename news fragment
jopemachine 4afa7b1
fix: Use `BigInt`
jopemachine 4dcb980
chore: update GraphQL schema dump
jopemachine 47fa15d
refactor: Add `HarborQuotaManager` *(Reflect feedback)
jopemachine 0ef1b35
fix: Use BigInt
jopemachine bf3e6aa
chore: self -> cls
jopemachine 4c34c01
chore: update GraphQL schema dump
jopemachine 34a6a54
fix: Improve exception handling
jopemachine db2b25d
feat: Add `test_harbor_read_project_quota`
jopemachine 00b9463
chore: `mock-group` -> `mock_group`
jopemachine 77a719d
fix: Disjoint `FIXTURES_FOR_HARBOR_CRUD_TEST` from `test_harbor_read_…
jopemachine 9814c4c
chore: Add registry type
jopemachine a74fb70
feat: Add create GQL mutation test case
jopemachine 234d0c9
feat: Add update, delete GQL mutation test cases
jopemachine d83b193
chore: fix typo
jopemachine 0e52491
feat: Add REST API `test_harbor_read_project_quota` test
jopemachine 0d7b6c7
chore: Rename variables
jopemachine d6625dc
fix: Add `test_harbor_update_project_quota` test
jopemachine 11969a5
chore: Hoist the variable
jopemachine 9c374a7
feat: Add `test_harbor_delete_project_quota` test
jopemachine 771ceaf
feat: Add `test_harbor_create_project_quota` test
jopemachine 1fcb3f8
fix: Change the `test_harbor_read_project_quota` test location
jopemachine e21327b
fix: Change test code location
jopemachine 11a7263
fix: Reuse `FIXTURES_FOR_HARBOR_CRUD_TEST`
jopemachine aa4bc87
fix: Broken CI
jopemachine 83332c8
refactor: Add `test_case` parametrize annotation
jopemachine d46bd31
refactor: `test_group` test cases using `test_case`
jopemachine c501ffb
fix: Broken CI
jopemachine da0d6e0
fix: Broken CI
jopemachine 3d80dc6
fix: Update milestone
jopemachine 305778d
fix: Update milestone
jopemachine 4860a60
fix: Update milestone
jopemachine 0dba50b
fix: Remove cyclic import
jopemachine 2185cc9
docs: Update milestone
jopemachine 0800ad7
fix: Broken import
jopemachine f8da8e4
chore: update api schema dump
jopemachine fd0ee6f
refactor: Implement `services_ctx` and refactoring using this
jopemachine 937bc8d
refactor: Reflect feedbacks
jopemachine d498374
fix: try to fix CI
jopemachine ff7382c
fix: Fix Broken CI
jopemachine 946565d
fix: Broken lint
jopemachine abbbd7a
fix: Broken test
jopemachine 51af272
refactor: improve abstraction
jopemachine 1b2bd51
refactor: improve abstraction
jopemachine 2bcb1cd
fix: Broken import
jopemachine a72a3fe
fix: Reflect feedback
jopemachine f477f33
fix: Reflect feedback
jopemachine c381c71
fix: Update version
jopemachine e552f0a
fix: Update version
jopemachine b695731
fix: Broken CI
jopemachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Implement CRUD API for managing Harbor per-project Quota. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fregataa Registry quota READ operation can be executed even if the user is not an admin.
However, it seems that GQL queries in the current SDK can only be executed through
Admin
.What do you think about adding this
query
,_query
functions toUser
as well?