Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(BA-620): Add Service Layer to Avoid Direct Volume and Vfolder Operations in Storage-Proxy Handler #3588

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MintCat98
Copy link
Contributor

@MintCat98 MintCat98 commented Feb 5, 2025

resolves #3554 (BA-620)

Implement volume service layer at service.py.

Also revised some parts of:

  • manager_handler.py
  • types.py
  • response_model.py
  • pool.py

for the service operations.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

📚 Documentation preview 📚: https://sorna--3588.org.readthedocs.build/en/3588/


📚 Documentation preview 📚: https://sorna-ko--3588.org.readthedocs.build/ko/3588/

@github-actions github-actions bot added area:docs Documentations comp:common Related to Common component comp:storage-proxy Related to Storage proxy component size:XL 500~ LoC labels Feb 5, 2025
@MintCat98 MintCat98 changed the base branch from main to refactor/volume-pool February 5, 2025 06:47
@github-actions github-actions bot added size:L 100~500 LoC size:XL 500~ LoC and removed size:XL 500~ LoC size:L 100~500 LoC labels Feb 5, 2025
@MintCat98 MintCat98 marked this pull request as ready for review February 6, 2025 08:08
@MintCat98 MintCat98 force-pushed the refactor/storage-service branch from e717a44 to 18e64fb Compare February 7, 2025 05:13
@MintCat98 MintCat98 changed the base branch from refactor/volume-pool to main February 7, 2025 05:13
@MintCat98 MintCat98 changed the base branch from main to refactor/volume-pool February 7, 2025 06:18
@MintCat98 MintCat98 changed the base branch from refactor/volume-pool to main February 7, 2025 06:18
@MintCat98 MintCat98 changed the base branch from main to refactor/volume-pool February 11, 2025 05:55
@MintCat98 MintCat98 force-pushed the refactor/volume-pool branch from cc8a81d to 02268b8 Compare February 11, 2025 06:52
@MintCat98 MintCat98 force-pushed the refactor/storage-service branch from a1ed810 to b6c7b90 Compare February 11, 2025 06:59
@MintCat98 MintCat98 force-pushed the refactor/volume-pool branch from 04dc82f to 01e569b Compare February 11, 2025 09:36
Base automatically changed from refactor/volume-pool to main February 11, 2025 09:44
@MintCat98 MintCat98 force-pushed the refactor/storage-service branch from b6c7b90 to b867312 Compare February 11, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentations comp:common Related to Common component comp:storage-proxy Related to Storage proxy component size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Service Layer to Avoid Direct Volume and Vfolder Operations in Storage-Proxy Handler
1 participant