refactor: snapshot store to diff #3155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c121914yu
reviewed
Nov 18, 2024
projects/app/src/pages/app/detail/components/WorkflowComponents/context/index.tsx
Outdated
Show resolved
Hide resolved
projects/app/src/pages/app/detail/components/WorkflowComponents/context/index.tsx
Outdated
Show resolved
Hide resolved
projects/app/src/pages/app/detail/components/WorkflowComponents/context/index.tsx
Show resolved
Hide resolved
projects/app/src/pages/app/detail/components/WorkflowComponents/context/index.tsx
Outdated
Show resolved
Hide resolved
projects/app/src/pages/app/detail/components/WorkflowComponents/context/index.tsx
Show resolved
Hide resolved
projects/app/src/pages/app/detail/components/WorkflowComponents/context/index.tsx
Outdated
Show resolved
Hide resolved
projects/app/src/pages/app/detail/components/SimpleApp/useSnapshots.tsx
Outdated
Show resolved
Hide resolved
| structuredClone(initialAppForm), | ||
| savedSnapshot?.diff | ||
| ) as AppSimpleEditFormType; | ||
| const val = compareSimpleAppSnapshot(pastState, appForm); |
There was a problem hiding this comment.
直接看，diff 是不是空的，应该就能知道了吧？不需要再比一次。
There was a problem hiding this comment.
保存的diff是和initialAppForm比的，这里应该得判断pastState和appForm的diff
There was a problem hiding this comment.
initialAppForm 不就是记录开始编辑的状态么？这里计算的是，是否保存，就是指，跟最初状态比。
projects/app/src/pages/app/detail/components/SimpleApp/Header.tsx
Outdated
Show resolved
Hide resolved
|
patch 方法封装起来，直接传入 diff 和 initState 即可获取最后结果。不要写这么复杂。 |
c121914yu
reviewed
Nov 19, 2024
|
|
||
| setPast((past) => [ | ||
| { | ||
| appForm, | ||
| diff, | ||
| title: title || formatTime2YMDHMS(new Date()), | ||
| isSaved | ||
| }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.