Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use http mode as default to sync registry contents #3659

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

fengxsong
Copy link
Collaborator

@fengxsong fengxsong commented Aug 10, 2023

🤖 Generated by Copilot at dc8e7a1

Refactor registry sync feature to use an interface and support HTTP and SSH modes. Delete unused code from system package and ssh.go file. Improve logging and error handling of sync process.

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Aug 10, 2023

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 885
✅ Successful 348
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 536
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (81609b2) 67.92% compared to head (e76c41d) 67.92%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3659   +/-   ##
=======================================
  Coverage   67.92%   67.92%           
=======================================
  Files           8        8           
  Lines         664      664           
=======================================
  Hits          451      451           
  Misses        171      171           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cuisongliu cuisongliu merged commit f482831 into labring:main Aug 10, 2023
68 checks passed
@sealos-ci-robot
Copy link
Member

/cherry-pick release-v4.3

@sealos-ci-robot
Copy link
Member

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/labring/sealos/actions/runs/5817100313

sealos-ci-robot pushed a commit that referenced this pull request Aug 10, 2023
cuisongliu pushed a commit that referenced this pull request Aug 10, 2023
@fengxsong fengxsong deleted the sync_registry branch August 23, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants