-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use http mode as default to sync registry contents #3659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated by lychee actionSummary
Full action output |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3659 +/- ##
=======================================
Coverage 67.92% 67.92%
=======================================
Files 8 8
Lines 664 664
=======================================
Hits 451 451
Misses 171 171
Partials 42 42 ☔ View full report in Codecov by Sentry. |
Signed-off-by: fengxsong <[email protected]>
fengxsong
force-pushed
the
sync_registry
branch
from
August 10, 2023 02:49
dc8e7a1
to
e76c41d
Compare
cuisongliu
approved these changes
Aug 10, 2023
/cherry-pick release-v4.3 |
🤖 says: cherry pick action finished successfully 🎉! |
sealos-ci-robot
pushed a commit
that referenced
this pull request
Aug 10, 2023
Signed-off-by: fengxsong <[email protected]>
cuisongliu
pushed a commit
that referenced
this pull request
Aug 10, 2023
…3661) Signed-off-by: fengxsong <[email protected]> Co-authored-by: fengxsong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at dc8e7a1
Refactor registry sync feature to use an interface and support HTTP and SSH modes. Delete unused code from
system
package andssh.go
file. Improve logging and error handling of sync process.