Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(skylight): Fix bug in skylight offsetting #736

Merged
merged 1 commit into from
Jan 31, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions dragonfly/building.py
Original file line number Diff line number Diff line change
Expand Up @@ -1629,13 +1629,13 @@ def convert_plenum_depths_to_room_2ds(self, tolerance=0.01):
"""Convert all of the Room2D ceiling/floor plenum depths to explicit Room2Ds.

This method is used under the hood of the translation from Dragonfly to
Honeybee in order to convert Room2D ceiling_plenum_depth and
Honeybee in order to convert Room2D ceiling_plenum_depth and
floor_plenum_depth properties into explicit 3D plenum Rooms.

However, it may be useful to call it explicitly (outside of
the translation) in order to edit the plenum Room2Ds. For example, multiple
plenum Room2Ds above several rooms can be joined together into a single
continuous plenum if this is how the plenum exists on the real building.
However, it may be useful to call it explicitly (outside of the translation)
in order to edit the plenum Room2Ds. For example, multiple plenum Room2Ds
above several rooms can be joined together into a single continuous
plenum if this is how the plenum exists on the real building.

Args:
tolerance: The maximum difference between point values for them to be
Expand Down
1 change: 1 addition & 0 deletions dragonfly/skylightparameter.py
Original file line number Diff line number Diff line change
Expand Up @@ -736,6 +736,7 @@ def offset_polygons_for_face(self, face_3d, offset_distance=0.05, tolerance=0.01
pt = pt.move(move_vec)
new_pts_2d.append(Point2D(pt.x, pt.y))
new_polygons.append(Polygon2D(new_pts_2d))
new_are_doors.append(isd)
else:
new_polygons.append(polygon)
new_are_doors.append(isd)
Expand Down