Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new challenge: NoReturn(advanced) #91

Closed
wants to merge 2 commits into from
Closed

new challenge: NoReturn(advanced) #91

wants to merge 2 commits into from

Conversation

frostming
Copy link
Contributor

Signed-off-by: Frost Ming [email protected]

@frostming
new challenge: NoReturn(advanced)
0a44013 
Signed-off-by: Frost Ming <[email protected]>
@frostming
fix tests
29efcd5 
Signed-off-by: Frost Ming <[email protected]>
@F-park
Copy link
Contributor

F-park commented Jan 19, 2024 •
edited
Loading

Starting in Python 3.11, the Never type should be used for this concept instead. Type checkers should treat the two equivalently.

Since we had never and never2, it is necessary to add NoReturn for challenge?

@laike9m
Copy link
Owner

laike9m commented Jan 19, 2024

I have the same question as F-park

@frostming
Copy link
Contributor Author

I am okay not adding this. Thanks.

@frostming frostming closed this Jan 19, 2024
@laike9m
Copy link
Owner

laike9m commented Jan 19, 2024

Thanks for understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frostming @F-park @laike9m